From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D7551C3C0B; Mon, 10 Feb 2025 09:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739179393; cv=none; b=jOQQRhcxibCoD5l8hj7af4OYAucKmKlcw/T1mZANr/NkSwyZz8rVkpTDgToIQYoBeHN8VZymfpcmaSd8eRXUtFbQtB77UP4kwL4RCJ4oWdWM5IXHNIDmitxptRnZk2oNZ0ZM6/es+shLBrisOhkVPX1ncFlmRmA42lN4ZsWcxE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739179393; c=relaxed/simple; bh=PnAHgzbOEcHmyOSqFq0WyWOa76JzbO1d4Wym5YXtycw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AZmythXK2O533Nz2SBwL2YK9t/d1PrwJ9oiXeyI/IXZbFkBIHWHRJ6rIb/PV05zERSlfi4995aU7vY8Ar+nRSNGAWiHi7voqTzXEzoj9jcYDvJncfKrqgDHfrEAvTKOJHRiHplDeoQOXhmHCMDuIjVX+VYUhpj1qIfwPxUQ7nz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ItZmqfIG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ItZmqfIG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EED49C4CED1; Mon, 10 Feb 2025 09:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739179393; bh=PnAHgzbOEcHmyOSqFq0WyWOa76JzbO1d4Wym5YXtycw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ItZmqfIGzU5zY3zNeah0bGAY+Li36UfqCN1XDiesjc2Jy2Y3VVG3ik8BwByFBlYVs EHLZRaay/0tdFL0RvLb9PBPUu4O1pUbLVOf45DhTaOI5v0NcxtKd50IIHuawum9Q6v F2Dz00UZ7ZXx0n2UZ6FEn0JnQrMO6RjlFEW1k1Fk8/QWN9nuOY2QN9INK3qNtim1Om Icu5FhTBLWVlHqefD1lcwXfAjDP30qA3RuWAPBXw1kPd2vaCr2yAidP+Fbpm6kW6sz 7Imigvjczw1yUX1rnc4XrfDCneJtkAtsDCJjfN2H0Z8oT6e3mjrBZvcfi4lnP3XS9F PSyYTdyYtRX0g== Message-ID: <60c7ed79-c344-4f6a-aefc-d6d45a4d9004@kernel.org> Date: Mon, 10 Feb 2025 10:23:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/3] firmware: add Exynos ACPM protocol driver To: Tudor Ambarus , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Alim Akhtar , Conor Dooley , Jassi Brar Cc: LKML , kernel-team@android.com, =?UTF-8?Q?Andr=C3=A9_Draszik?= , Arnd Bergmann , Daniel Lezcano , Peter Griffin , Rob Herring , Ulf Hansson , Vincent Guittot , Will McVicker References: <20250207-gs101-acpm-v7-2-ffd7b2fb15ae@linaro.org> <503b7ec9-e0b1-4351-aa34-3089b2055eb9@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <503b7ec9-e0b1-4351-aa34-3089b2055eb9@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 10/02/2025 09:59, Tudor Ambarus wrote: > > > On 2/8/25 3:31 PM, Markus Elfring wrote: >> … >>> +++ b/drivers/firmware/samsung/exynos-acpm.c >>> @@ -0,0 +1,771 @@ >> … >>> +static int acpm_dequeue_by_polling(struct acpm_chan *achan, >>> + const struct acpm_xfer *xfer) >>> +{ >> … >>> + do { >>> + mutex_lock(&achan->rx_lock); >>> + ret = acpm_get_rx(achan, xfer); >>> + mutex_unlock(&achan->rx_lock); >> … >> >> Under which circumstances would you become interested to apply a statement >> like “guard(mutex)(&achan->rx_lock);”? >> https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/mutex.h#L201 > > I'll replace the open-coded mutex handling with cleanup.h guard(mutex) > and scoped_guard(mutex, ...), thanks. FYI, Markus is PLONKed so I won't ever see what he writes.
Feel free to ignore all comments from Markus, regardless whether the suggestion is reasonable or not. Several maintainers ignore Markus' feedback, because it is just a waste of time.
Best regards, Krzysztof