From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: tony@atomide.com, robh@kernel.org, wens@csie.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: twl4030-power: Revert to use of_match_device()
Date: Thu, 23 Nov 2023 17:42:45 +0200 [thread overview]
Message-ID: <60e1ee8c-870a-4d38-bad8-bc28e98ee425@gmail.com> (raw)
In-Reply-To: <20231123103906.GE1184245@google.com>
On 23/11/2023 12:39, Lee Jones wrote:
> On Sun, 29 Oct 2023, Peter Ujfalusi wrote:
>
>> The core twl chip is probed via i2c and the dev->driver->of_match_table is
>> NULL, causing the driver to fail to probe.
>>
>> This partially reverts commit 1e0c866887f4.
>>
>> Fixes: 1e0c866887f4 ("mfd: Use device_get_match_data() in a bunch of drivers")
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>> ---
>> drivers/mfd/twl4030-power.c | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> Rob, does this work for you?
This is not needed, twl4030-power is a proper platform device, it should
have of_match_data.
I had a boot failure likely caused by something else and I thought this
might be part of the puzzle to get it working again.
Sorry for the confusion.
--
Péter
prev parent reply other threads:[~2023-11-23 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 11:49 [PATCH] mfd: twl4030-power: Revert to use of_match_device() Peter Ujfalusi
2023-11-23 10:39 ` Lee Jones
2023-11-23 15:42 ` Péter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60e1ee8c-870a-4d38-bad8-bc28e98ee425@gmail.com \
--to=peter.ujfalusi@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox