From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 156291F5EA for ; Sat, 2 May 2026 06:05:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777701945; cv=none; b=K50odPR+VDIXsjVV9noQ8HNfymvM2PwAP3gFL0czwWVYtTVMx9wpyC4GA7efRX9OUEmObE6SYwSBOlLjWvEL31IARCQAtzDHKvv6JB8/UYDXoV5biCICGvhvY8ZClMR2JvqEdaP5B+5qijmUXtzuGkNih2N1mmCB+A+f43mdhxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777701945; c=relaxed/simple; bh=X/hZCb0jhWMLtO0yzfJTyu1aVwl+6kQirfxui/Burbw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TUZykWGdUHGAlUGJecmlR6kqud14HHfG1diWw0ORtJ2VaG77Y/xmEaOHuXfDQCB7KKE9AHtBLj+irB2K3gWct77mIHW8Ur8YLKA4oNcIJszJbBZFZMXRyM4lTeI4AhODTiph6kJID5viEmFMBjP/TG0iSmg1c6/WEeFAp7gmhzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b=gYykFdUD; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall.org header.i=@blackwall.org header.b="gYykFdUD" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48a3e9862f0so15587065e9.1 for ; Fri, 01 May 2026 23:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall.org; s=google; t=1777701942; x=1778306742; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Hb311y/HjKGqfYjiqwo0iWKOc8y7rqDPGTnOkcrspE8=; b=gYykFdUDDi2ROI6LbXOHU3TdkfVmdZjcslOVXt4bIBdCYVFtWJYrdomHd/mX4aUjMZ Q9X+z3BvUJ00AfUCNWiSm616pj8jk63wDt0Su3i4xwcN3AqhLQXTCj60lx0bwOzk3iYd TNADnzqemOfQqzQ4dk9M/nsouo37c/M2qqMoczwEzm0gYasP+Sz5phgxUZPGKN11gi72 aJdVcUtDgFa+aQbSApjtC27j8lrmjKaVY/93e7HwbM+tis6xRJJagWtEHoSlEw9aML3I rGrgQZFzzUZu9nhPC9KSS02X+VYaWv8FIKs7eP+wGy0lJWKiFFCQqtPQ8LDG61MPGVkO Ju+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777701942; x=1778306742; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hb311y/HjKGqfYjiqwo0iWKOc8y7rqDPGTnOkcrspE8=; b=Ws9Uc/8C+XL1/tO1fpHEBSEODzJuBGNZz+P5fHhFW3ppGQXiaI2nCWoa9pVTc1geUp 32t+8DP0dh3Tk73uSP5keFR3VjdLmU7XFy6eo/VLJM95IL1jEtwiuL2s/+U4Ygkrjz4z wTPlyBbOIj0OHCGaoSxztGApLqCeXbeyIFoO4S/YIw9fr6mGd/GyALVgqLJZQVNsk2sn elTTS7v7KYUl57GdX+UWMZMj36t7VquS73qiZiF2aI4c55a+Rs5YLbhLzF3xSsBIEj/w 8Ek5MQVM+OrY2WzdOZ0igfqKvpHKnvJg4BBWRQq1UAG//1pzN2JWfNYC+28v9WgMNyae huNA== X-Forwarded-Encrypted: i=1; AFNElJ/fBGhgIBI7QAtSKblrZm+aBeq20lHcgCFuSRE6a9/AYdcRRFDVgVS7yxdes5PNp6gLnLsciyxwDpbaVBw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf8RWNzKg1y4PFbvrU/KypLvKFOhQb8NsUC0+VCG7odV1G/fIz OExKMsB2bHBMZEZMDsM8A8TG5HhNljIUrRyCrA5Dr2C9t/aTIdM944ZPpGr2ghhOpkQ= X-Gm-Gg: AeBDiesUi0cuLThvYw3fL8gvGiRt8xEXaR0KnHwsCzhac+/WaAxsu7R5beo6eL4+PJ7 br7ClMOpRg7wKw94DfTpVr3c/GChcb817HF/kytyrmZ16YaPitoHZw8nSW2oXQ9cb5IKHG3n3i4 LoJAphFZsSnOvgxBa2hNkOs7Kc6uSqcNReHTfpAMM3S2Q1lEoQyzJHqkWRRGDcGwCZEwK9S64gp N3amKMRzA3O4NgZb+27vyed05xXRgg9Qot/JdEdaX6ppwz40OfmEIjf4qCulutR+UdoaddcGIRC EA++cdhmZxAH1SiOwhI9rXXZ819vEUydvQgWHmsZ5CwyRK+5qWoKbzq+k3ywtWGMkf2zMw83P8I ludSLnRIfmM+HQNYNdplAM4o2EPd+BK2yGhhIgg8DJtYw5oUNK2DK9bN8rZ+ZyAQvE8Rtlkpuhc SlrLd7c0NNkeJzAx4ssbgrBEAyNU3Yd+a9bOTt/zrvtLfFq9cMJQ1aqlrTbGDQG7+6 X-Received: by 2002:a05:600c:4f13:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-48a970fda7bmr29905755e9.12.1777701942442; Fri, 01 May 2026 23:05:42 -0700 (PDT) Received: from [192.168.0.161] (78-154-15-182.ip.btc-net.bg. [78.154.15.182]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a822c3422sm157004635e9.8.2026.05.01.23.05.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2026 23:05:41 -0700 (PDT) Message-ID: <60fd2cc4-1c04-4db6-97cd-bc3bb9710a04@blackwall.org> Date: Sat, 2 May 2026 09:05:40 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 4/5] ipv6: mld: encode multicast exponential fields Content-Language: en-US, bg To: Ujjal Roy , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Ido Schimmel , David Ahern , Shuah Khan , Andy Roulin , Yong Wang , Petr Machata Cc: Ujjal Roy , bridge@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260501173130.3486-1-royujjal@gmail.com> <20260501173130.3486-5-royujjal@gmail.com> From: Nikolay Aleksandrov In-Reply-To: <20260501173130.3486-5-royujjal@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/05/2026 20:31, Ujjal Roy wrote: > In MLD, MRC and QQIC fields are not correctly encoded when > generating query packets. Since the receiver of the query > interprets these fields using the MLDv2 floating-point > decoding logic, any value that exceeds the linear threshold > is incorrectly parsed as an exponential value, leading to > an incorrect interval calculation. > > Encode and assign the corresponding protocol fields during > query generation. Introduce the logic to dynamically > calculate the exponent and mantissa using bit-scan (fls). > This ensures MRC (16-bit) and QQIC (8-bit) fields are > properly encoded when transmitting query packets with > intervals that exceed their respective linear thresholds > (32768 for MRD; 128 for QQI). > > RFC3810: If Maximum Response Code >= 32768, the Maximum > Response Code field represents a floating-point value as > follows: > 0 1 2 3 4 5 6 7 8 9 A B C D E F > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > |1| exp | mant | > +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > > RFC3810: If QQIC >= 128, the QQIC field represents a > floating-point value as follows: > 0 1 2 3 4 5 6 7 > +-+-+-+-+-+-+-+-+ > |1| exp | mant | > +-+-+-+-+-+-+-+-+ > > Reviewed-by: Ido Schimmel > Signed-off-by: Ujjal Roy > --- > include/net/mld.h | 119 ++++++++++++++++++++++++++++++++++++++ > net/bridge/br_multicast.c | 4 +- > 2 files changed, 121 insertions(+), 2 deletions(-) > Reviewed-by: Nikolay Aleksandrov