From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754170AbcESKVq (ORCPT ); Thu, 19 May 2016 06:21:46 -0400 Received: from webbox1416.server-home.net ([77.236.96.61]:49789 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbcESKVp (ORCPT ); Thu, 19 May 2016 06:21:45 -0400 From: Alexander Stein To: Mathias Kresin Cc: John Crispin , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, "Mehrtens, Hauke" Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Date: Thu, 19 May 2016 12:21:38 +0200 Message-ID: <6103030.g2sqFmaRhG@ws-stein> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.16; x86_64; ; ) In-Reply-To: References: <1463587403-26809-1-git-send-email-alexander.stein@systec-electronic.com> <5f2d9a6d-bcf1-5aa1-7c45-f8cfd723bc3a@phrozen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 19 May 2016 12:03:10, Mathias Kresin wrote: > 2016-05-19 9:03 GMT+02:00 John Crispin : > > On 19/05/2016 08:57, Alexander Stein wrote: > >> Thanks for the link, I wasn't aware of that patch. I like it in general, > >> but there are some things I'd like to get addressed first: > >> * vr9_gphy_of_reg_init() writes uncoditionally to led3h and led3l even on > >> > >> PEf7071 which does not have this register at all > > > > we use this driver mainly on the 11g and 22f version. mathias recently > > added the led3 handling. > > > > @Mathias, can you have a look at this and fix it inside the lede tree ? > > Well, I haven't added the led3 handling, I've only changed the initial > value (function) of led3. > > Maybe it's cleaner to not use a default value for the led function and > completely rely on the device tree bindings. But by adjusting the > initial values, I had to change only the led function of one board in > the openwrt xrx200 subtarget instead of touching all dts files. I think setting default values is good. > I know that the LTQ Datasheet for the PEF 7071 Version 1.5 mentions > the led3 control register albeit there is no pin for a forth led. So I > guess it's safe to write to the led3 register even for the PEF 7071. Mh, my PEF 7071 User Manual (Version 2.0, 2012-10-17) doesn't mention LED3x registers. There is LED3DA and LED3EN in PHY_LED but was removed in 1.6 manual. I think, some flag if the PHY supports LED3 and depend on that is just fine. Best regards, Alexander