From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1436DEB64DA for ; Tue, 4 Jul 2023 07:07:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231252AbjGDHHx (ORCPT ); Tue, 4 Jul 2023 03:07:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230197AbjGDHHu (ORCPT ); Tue, 4 Jul 2023 03:07:50 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFB1C130; Tue, 4 Jul 2023 00:07:46 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 570B78159; Tue, 4 Jul 2023 15:07:45 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 4 Jul 2023 15:07:44 +0800 Received: from [192.168.125.128] (113.72.144.31) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 4 Jul 2023 15:07:43 +0800 Message-ID: <61120362-6b19-3683-db18-8d703ae278eb@starfivetech.com> Date: Tue, 4 Jul 2023 15:04:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v6 2/7] dt-bindings: soc: starfive: Add StarFive syscon module Content-Language: en-US To: Krzysztof Kozlowski CC: , , "Michael Turquette" , Stephen Boyd , "Rob Herring" , Philipp Zabel , "Conor Dooley" , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , William Qiu , , References: <20230704020239.288500-1-xingyu.wu@starfivetech.com> <20230704020239.288500-3-xingyu.wu@starfivetech.com> From: Xingyu Wu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.31] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/4 14:30, Krzysztof Kozlowski wrote: > On 04/07/2023 04:02, Xingyu Wu wrote: >> From: William Qiu >> >> Add documentation to describe StarFive System Controller Registers. >> >> Co-developed-by: Xingyu Wu >> Signed-off-by: Xingyu Wu >> Signed-off-by: William Qiu > > I don't think there is a point in reviewing bindings which were never > tested. I hope you agree with me. > > The patch just introduces errors. :( > Sorry, it was my fault. I tested it but found the example uncompleted. And I forgot to test it after completing it. Sorry. Best regards, Xingyu Wu