From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A17C3F2CD for ; Mon, 2 Mar 2020 16:44:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D0C521D56 for ; Mon, 2 Mar 2020 16:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583167495; bh=8KCEg3dL32BCeilX8qMRabMF5ha5P0abQyGvrIRP/QQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=ZAjueoJAhlDI8ppM754zuXHMirtejA4E88u+dvXmyFS8Zd+5kTU0pT/9viBronhth 2+nzRKdEWA/24Zb/bWi7L9nDHMVBN1sxPd4alLfZzX+JSjzbotbWar/Zr22558u4BN 84PwkjvqL0xeJNNg8SGW1H7giDhCuRrieanLV/Bg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727250AbgCBQoy (ORCPT ); Mon, 2 Mar 2020 11:44:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:48954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbgCBQox (ORCPT ); Mon, 2 Mar 2020 11:44:53 -0500 Received: from [10.92.140.24] (unknown [167.220.149.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D58472173E; Mon, 2 Mar 2020 16:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583167492; bh=8KCEg3dL32BCeilX8qMRabMF5ha5P0abQyGvrIRP/QQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PJvR1jjHJGFx2PAKkwkzM7pi1XQlhwg5hroIkYkdLfRjuEvnl/ICkKtow7EDVl63M rq2W+HTFhAWWDGTFVeZG/nO84VK279lgBwFQQj4FGjsxlcer9srwiTKBGSAf9MjWGX xHP2VM+nt/kIUuf9Xsf1pYqm4updJlUg8Z9gqi0g= Subject: Re: About commit "io: change inX() to have their own IO barrier overrides" To: John Garry , Arnd Bergmann Cc: "xuwei (O)" , Bjorn Helgaas , "linux-kernel@vger.kernel.org" , Jiaxun Yang References: <2e80d7bc-32a0-cc40-00a9-8a383a1966c2@huawei.com> <8207cd51-5b94-2f15-de9f-d85c9c385bca@huawei.com> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: <6115fa56-a471-1e9f-edbb-e643fa4e7e11@kernel.org> Date: Mon, 2 Mar 2020 11:44:50 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <8207cd51-5b94-2f15-de9f-d85c9c385bca@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/2/2020 7:35 AM, John Garry wrote: > Hi Sinan, > > Thanks for getting back to me. > >> On 2/28/2020 4:52 AM, John Garry wrote: >>> About the commit in the $subject 87fe2d543f81, would there be any >>> specific reason why the logic pio versions of these functions did not >>> get the same treatment > > In fact, your changes and the logic PIO changes went in at the same time. > > or should not? I'm talking about lib/logic_pio.c I think your change missed "cross-architecture" category. > > #define BUILD_LOGIC_IO(bw, type)                    > type logic_in##bw(unsigned long addr)                    > {                                    >     type ret = (type)~0;                        >     if (addr < MMIO_UPPER_LIMIT) {                    >         ret = read##bw(PCI_IOBASE + addr); ***    >     } else if (addr >= MMIO_UPPER_LIMIT && addr < IO_SPACE_LIMIT) { >         struct logic_pio_hwaddr *entry = find_io_range(addr);    >                                     >         if (entry)                        >             ret = entry->ops->in(entry->hostdata,        >                     addr, sizeof(type));        >         else                            >             WARN_ON_ONCE(1);                >     }                                >     return ret;                            > }        > >> How is the behavior on different architectures? > > So today only ARM64 uses it for this relevant code, above. But maybe > others in future will want to use it - any arch without native IO port > access is a candidate. I'm looking at Arnd here for help. > >> >> As long as the expectations are set, I see no reason why it shouldn't >> but, I'll let Arnd comment on it too. > > ok, so it looks reasonable consider replicating your change for ***, above. Arnd is the maintainer here. We should consult first. I believe there is also a linux-arch mailing list. Going there with this question makes sense IMO. > > Thanks, > John