From: Keith Owens <kaos@ocs.com.au>
To: ankry@green.mif.pg.gda.pl
Cc: jgarzik@mandrakesoft.com (Jeff Garzik),
elenstev@mesatop.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error
Date: Thu, 28 Jun 2001 20:43:38 +1000 [thread overview]
Message-ID: <6121.993725018@ocs3.ocs-net> (raw)
In-Reply-To: Your message of "Thu, 28 Jun 2001 10:45:55 +0200." <200106280845.KAA20122@sunrise.pg.gda.pl>
On Thu, 28 Jun 2001 10:45:55 +0200 (MET DST),
Andrzej Krzysztofowicz <ankry@pg.gda.pl> wrote:
>Keith Owens wrote:
>> Index: 6-pre6.1/drivers/net/Config.in
>> - dep_bool ' EISA, VLB, PCI and on board controllers' CONFIG_NET_PCI
>> + if [ "$CONFIG_ISA" = "y" -o "$CONFIG_EISA" = "y" -o "$CONFIG_PCI" = "y" ]; then
>CONFIG_EISA check in this condition is redundant.
True, but the line is a cut and paste from higher up in
drivers/net/Config.in. Even though it is redundant, it is consistent
with the rest of the file.
drivers/net/Config.in needs a major cleanup, lots of the if statements
can go and be replaced by dep_xxx statements, CONFIG_ETHERTAP is marked
obsolete but is tested against experimental, CONFIG_ZNET is marked
experimental but is tested against obsolete, etc. I started to clean
up the file then decided to leave it, the entire thing is being
replaced in 2.5 anyway.
next prev parent reply other threads:[~2001-06-28 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-28 3:09 [PATCH] 2.4.6-pre6 fix drivers/net/Config.in error Steven Cole
2001-06-28 4:07 ` Jeff Garzik
2001-06-28 6:14 ` Keith Owens
2001-06-28 8:45 ` Andrzej Krzysztofowicz
2001-06-28 10:43 ` Keith Owens [this message]
2001-06-28 20:40 ` Jeff Garzik
2001-06-29 0:37 ` Keith Owens
2001-06-29 12:31 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6121.993725018@ocs3.ocs-net \
--to=kaos@ocs.com.au \
--cc=ankry@green.mif.pg.gda.pl \
--cc=elenstev@mesatop.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox