From: Eli Billauer <eli.billauer@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: gregkh <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v1 0/4] char: xillybus: Remove usage of the deprecated 'pci-dma-compat.h' API
Date: Sun, 29 Aug 2021 11:23:06 +0300 [thread overview]
Message-ID: <612B43EA.2090009@gmail.com> (raw)
In-Reply-To: <CAK8P3a1=tZkb-rxj5Ys_FgUa=qoKPD6fpPjEMHXDL0QwwS0zgg@mail.gmail.com>
On 29/08/21 00:26, Arnd Bergmann wrote:
>
> The documentation was updated 11 years ago to only describe the modern
> linux/dma-mapping.h interfaces and mark the old bus-specific ones as
> no longer recommended, see 216bf58f4092 ("Documentation: convert
> PCI-DMA-mapping.txt to use the generic DMA API").
>
Thanks, Arnd. That's exactly the kind of reference I was asking about.
And of course, a thanks goes to Christophe as well for drawing my
attention to this issue. A bit surprising it didn't happen back in 2013,
when the driver was included in the kernel. Or possibly in 2014, when it
went out of staging.
As for this patch set, three out of four patches make modifications in
functions that should be deleted altogether. Their only purpose is to
wrap DMA-related calls made by the core driver, so that the pci_* API is
used for PCI devices, and the dma_* API otherwise. As it turns out, this
was a lot of nonsense code from day one.
I'll prepare a patch that removes all this.
Thanks again,
Eli
prev parent reply other threads:[~2021-08-29 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 17:17 [PATCH v1 0/4] char: xillybus: Remove usage of the deprecated 'pci-dma-compat.h' API Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 1/4] " Christophe JAILLET
2021-11-03 18:38 ` Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 2/4] char: xillybus: Remove usage of 'pci_unmap_single()' Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 3/4] char: xillybus: Remove usage of remaining deprecated pci_ API Christophe JAILLET
2021-08-30 9:48 ` Dan Carpenter
2021-08-30 17:19 ` Christophe JAILLET
2021-08-27 17:17 ` [PATCH v1 4/4] char: xillybus: Simplify 'xillybus_init_endpoint()' Christophe JAILLET
2021-08-28 15:05 ` [PATCH v1 0/4] char: xillybus: Remove usage of the deprecated 'pci-dma-compat.h' API Eli Billauer
2021-08-28 21:26 ` Arnd Bergmann
2021-08-29 8:23 ` Eli Billauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=612B43EA.2090009@gmail.com \
--to=eli.billauer@gmail.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox