From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbbJFJS3 (ORCPT ); Tue, 6 Oct 2015 05:18:29 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:58867 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbJFJSZ (ORCPT ); Tue, 6 Oct 2015 05:18:25 -0400 From: Arnd Bergmann To: Marc Kleine-Budde Cc: Oliver Hartkopp , netdev@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, "David S. Miller" , linux-can@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 12/12] [RFC] can: avoid using timeval for uapi Date: Tue, 06 Oct 2015 11:18:08 +0200 Message-ID: <6130832.516TFPqmA3@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56138EDC.8080501@pengutronix.de> References: <1443612402-3000775-1-git-send-email-arnd@arndb.de> <7548522.iLToS4O3HD@wuerfel> <56138EDC.8080501@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:7bP5WTaDD8Y31CDip0BvMXJwwi05Sfr7TchelORmmXMRkyIA1SK /WXgzOL4B9rPTePmNS8d/r9CLXHxlgTqDUfbUgA++qDf/1WOYU2VjRc/lDl9TK2IJmfrlsZ r/RRMY9eGHw41sq6w3pqKGGTsy0SPuH05ecIopes3U4w7HLW7UCs6D7TYqW25ex9Qjg7BO6 QQqKowjX0MB9NCbF4LdYw== X-UI-Out-Filterresults: notjunk:1;V01:K0:HKFbN69V3m8=:ymUyvn+c5QpeKZudcyOmgw lh1EYPCdQb1s/osvcLhAEI4JicQeeUPw5i32BFwqK6++X4NCRWiqPNLiCBGNVtW1k4QGPl22s hy2YuJy0udgXK/CMZrdDktr2vDqKd5aDrmwj1qPqFRn9CE8QprAI7tCC9uBZ/ZVwBoeNgk6jv 7UafST7DMWrWU8Lw0K/NWI7NcZz+LWD/vfSe859xW0nrghfgv85jSKsbNPEFsN1WIYujD4gY9 +PyUc0hombeAPnNQhw1cjzOFaDzMJSQ4TX/isyWufqD3FcHgq46h6UQBnoRiJgB9/SCTDhO4Z OWbH40lNBN64Sns7IBrKmonaHEm6+OpWCfR6DH+ZqK/gxRWo25xOnrBvV/2zIM4bDeX60lP0p snB8Jrhxe8raQMWvCI9mDGFdAPLq6AhHJxCgzv67O57zPgPqJIMlRfH0sevsgHGaOEFg3grwz LvRz3zHS6pmQGBNnEGMeE+ViJ/ECq3Mrvafr3yRaQHJW6vGbXhGEkPoqoUNEnrHG9WLTQseHc kSLX5j3V8CH+JjZHsSwgIduJWXul40fTO8pmRg8lkKXTPzRXsoSdO7Wf/ugTzXBdbCKmE/9lA osn3A1GbK8XymcDpnmh0FB7h/cvbbbAvv60DVyTaPxpCdHU2oUY5QE551RXz1FmgJO4LiX7v2 lfWPI04HrvQ+cpJF8B4PMS/kC9TDsDxB+2MdujdRkQm672LR1vHIUKUvBpPYqxWVVghiIU4py YRlPwndamRsVPig1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 06 October 2015 11:05:32 Marc Kleine-Budde wrote: > On 10/06/2015 10:32 AM, Arnd Bergmann wrote: > > On Monday 05 October 2015 20:51:08 Oliver Hartkopp wrote: > >> > >> I double checked some (more) BCM applications I have access to. > >> > >> E.g. https://github.com/linux-can/can-tests > >> > >> When you do a 'git grep ival1' there you get something like > >> > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_sec = 1; > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_usec = 0; > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_sec = 0; > >> tst-bcm-cycle.c: msg.msg_head.ival1.tv_usec = 0; > >> tst-bcm-dump.c: msg.msg_head.ival1.tv_sec = timeout / 1000000; > >> tst-bcm-dump.c: msg.msg_head.ival1.tv_usec = timeout % 1000000; > >> (..) > >> > >> So the usual way to assign values to ival1 and ival2 is NOT to assign an > >> existing struct timeval but to directly assign its tv_[u]sec elements. > > > > Ok, very good. > > > >> I applied your bcm.h changes to my local can-tests tree and it compiles > >> without any problems - as expected. I don't see any serious drawback with your > >> idea. I wonder whether developers would ever notice this change ... > >> > >>> We could address problem a) by using '__u32' or 'int' members > >>> rather than 'long', but that would have a more significant > >>> downside in also breaking support for all existing 64-bit user > >>> binaries that might be using this interface, which is likely > >>> not acceptable. > >> > >> Indeed. > >> > >>> Signed-off-by: Arnd Bergmann > >>> Cc: Oliver Hartkopp > >> > >> Thanks for your good suggestion to make the BCM API y2038 proof! > >> > >> Acked-by: Oliver Hartkopp > > > > Thanks. > > > > What is the normal path for CAN patches? Should I resend with your > > Ack and without the RFC for Marc to pick it up? > > You can add my: > > Acked-by: Marc Kleine-Budde > > add upstream the 2038 fixes as a block. Davem already picked up the first 10 of the series. If you don't mind, I'd prefer if you could take this one into your tree so I have it off my list. I have 200 other patches in various states and more getting added. Arnd