public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: Wei Ni <wni@nvidia.com>
Cc: swarren@nvidia.com, olof@lixom.net, ccross@android.com,
	linux@arm.linux.org.uk, linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, ldewangan@nvidia.com,
	arnd@arndb.de, grant.likely@secretlab.ca, cjb@laptop.org
Subject: Re: [PATCH 1/5] ARM: tegra: set up wlan clocks for tegra dt
Date: Wed, 04 Jul 2012 12:43:50 +0200	[thread overview]
Message-ID: <6135516.CD1aogiCta@fb07-iapwap2> (raw)
In-Reply-To: <1341394488-13169-2-git-send-email-wni@nvidia.com>

Am Mittwoch, 4. Juli 2012, 17:34:44 schrieb Wei Ni:
> Set up the wlan clock tree for Tegra20 and Tegra30.
> 
> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
>  arch/arm/mach-tegra/board-dt-tegra20.c |    1 +
>  arch/arm/mach-tegra/board-dt-tegra30.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-tegra/board-dt-tegra20.c
> b/arch/arm/mach-tegra/board-dt-tegra20.c index 70a19a9..fbcc7d9 100644
> --- a/arch/arm/mach-tegra/board-dt-tegra20.c
> +++ b/arch/arm/mach-tegra/board-dt-tegra20.c
> @@ -78,6 +78,7 @@ static __initdata struct tegra_clk_init_table
> tegra_dt_clk_init_table[] = { { "pll_a",      "pll_p_out1",   56448000,    
>   true },
>  	{ "pll_a_out0", "pll_a",        11289600,       true },
>  	{ "cdev1",      NULL,           0,              true },
> +	{ "blink",      "clk_32k",      32768,          true },

what's the reason to enable this on all boards? Would it make sense to set 
this to "false" instead?

Marc


>  	{ "i2s1",       "pll_a_out0",   11289600,       false},
>  	{ "i2s2",       "pll_a_out0",   11289600,       false},
>  	{ NULL,		NULL,		0,		0},
> diff --git a/arch/arm/mach-tegra/board-dt-tegra30.c
> b/arch/arm/mach-tegra/board-dt-tegra30.c index 53bf60f..2d73c61 100644
> --- a/arch/arm/mach-tegra/board-dt-tegra30.c
> +++ b/arch/arm/mach-tegra/board-dt-tegra30.c
> @@ -61,6 +61,7 @@ static __initdata struct tegra_clk_init_table
> tegra_dt_clk_init_table[] = { { "pll_a_out0",	"pll_a",	11289600,	true },
>  	{ "extern1",	"pll_a_out0",	0,		true },
>  	{ "clk_out_1",	"extern1",	0,		true },
> +	{ "blink",	"clk_32k",	32768,		true },
>  	{ "i2s0",	"pll_a_out0",	11289600,	false},
>  	{ "i2s1",	"pll_a_out0",	11289600,	false},
>  	{ "i2s2",	"pll_a_out0",	11289600,	false},

  reply	other threads:[~2012-07-04 10:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04  9:34 [PATCH 0/5] ARM: tegra: enable wlan for t20 and t30 Wei Ni
2012-07-04  9:34 ` [PATCH 1/5] ARM: tegra: set up wlan clocks for tegra dt Wei Ni
2012-07-04 10:43   ` Marc Dietrich [this message]
2012-07-04 11:23     ` Wei Ni
2012-07-04 11:51       ` Marc Dietrich
2012-07-05  3:18         ` Wei Ni
2012-07-05  8:39           ` Marc Dietrich
2012-07-04  9:34 ` [PATCH 2/5] ARM: dt: t20 seaboard: add pinmux, gpio for wlan Wei Ni
2012-07-04  9:34 ` [PATCH 3/5] ARM: dt: t20 ventana: " Wei Ni
2012-07-04  9:34 ` [PATCH 4/5] ARM: dt: t30 cardhu: " Wei Ni
2012-07-04  9:34 ` [PATCH 5/5] ARM: tegra: enable wireless in defconfig Wei Ni
2012-07-05 19:59   ` Stephen Warren
2012-07-05 20:35     ` Marc Dietrich
2012-07-05 20:42       ` Stephen Warren
2012-07-06  3:19         ` Wei Ni
2012-07-06  3:08     ` Wei Ni
2012-07-06 15:42       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6135516.CD1aogiCta@fb07-iapwap2 \
    --to=marvin24@gmx.de \
    --cc=arnd@arndb.de \
    --cc=ccross@android.com \
    --cc=cjb@laptop.org \
    --cc=grant.likely@secretlab.ca \
    --cc=ldewangan@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=swarren@nvidia.com \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox