From: Adrian Hunter <adrian.hunter@intel.com>
To: "Kornel Dulęba" <korneld@chromium.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ritesh Harjani <riteshh@codeaurora.org>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Radoslaw Biernacki <biernacki@google.com>,
Guenter Roeck <groeck@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
upstream@semihalf.com
Subject: Re: [PATCH] mmc: cqhci: Be more verbose in error irq handler
Date: Fri, 20 Oct 2023 10:40:52 +0300 [thread overview]
Message-ID: <613c51f0-c32e-4de5-9627-525d92fb06ed@intel.com> (raw)
In-Reply-To: <20231016095610.1095084-1-korneld@chromium.org>
On 16/10/23 12:56, Kornel Dulęba wrote:
> There are several reasons for controller to generate an error interrupt.
> They include controller<->card timeout, and CRC mismatch error.
> Right now we only get one line in the logs stating that CQE recovery was
> triggered, but with no information about what caused it.
> To figure out what happened be more verbose and dump the registers from
> irq error handler logic.
> This matches the behaviour of the software timeout logic, see
> cqhci_timeout.
>
> Signed-off-by: Kornel Dulęba <korneld@chromium.org>
> ---
> drivers/mmc/host/cqhci-core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index b3d7d6d8d654..33abb4bd53b5 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -700,8 +700,9 @@ static void cqhci_error_irq(struct mmc_host *mmc, u32 status, int cmd_error,
>
> terri = cqhci_readl(cq_host, CQHCI_TERRI);
>
> - pr_debug("%s: cqhci: error IRQ status: 0x%08x cmd error %d data error %d TERRI: 0x%08x\n",
> - mmc_hostname(mmc), status, cmd_error, data_error, terri);
> + pr_warn("%s: cqhci: error IRQ status: 0x%08x cmd error %d data error %d\n",
> + mmc_hostname(mmc), status, cmd_error, data_error);
> + cqhci_dumpregs(cq_host);
For debugging, isn't dynamic debug seems more appropriate?
>
> /* Forget about errors when recovery has already been triggered */
> if (cq_host->recovery_halt)
next prev parent reply other threads:[~2023-10-20 7:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 9:56 [PATCH] mmc: cqhci: Be more verbose in error irq handler Kornel Dulęba
2023-10-20 7:40 ` Adrian Hunter [this message]
2023-10-20 8:53 ` Kornel Dulęba
2023-10-23 11:38 ` Adrian Hunter
2023-10-25 8:01 ` Kornel Dulęba
2023-10-26 6:25 ` Adrian Hunter
2023-10-26 7:56 ` Kornel Dulęba
2023-10-26 8:14 ` Adrian Hunter
2023-10-26 8:29 ` Kornel Dulęba
2023-10-26 8:51 ` Adrian Hunter
2023-10-26 9:32 ` Kornel Dulęba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=613c51f0-c32e-4de5-9627-525d92fb06ed@intel.com \
--to=adrian.hunter@intel.com \
--cc=biernacki@google.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=korneld@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_asutoshd@quicinc.com \
--cc=riteshh@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox