From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <agross@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v2 1/3] ARM: qcom: Make an option for qcom clocksource platforms
Date: Wed, 25 Nov 2015 23:08:28 +0100 [thread overview]
Message-ID: <6140735.DAZiajTbh1@wuerfel> (raw)
In-Reply-To: <1448485478-21699-2-git-send-email-sboyd@codeaurora.org>
On Wednesday 25 November 2015 13:04:36 Stephen Boyd wrote:
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 2c2b28ee4811..999d523ac09f 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -148,8 +148,7 @@ textofs-$(CONFIG_PM_H1940) := 0x00108000
> ifeq ($(CONFIG_ARCH_SA1100),y)
> textofs-$(CONFIG_SA1111) := 0x00208000
> endif
> -textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
> -textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
> +textofs-$(CONFIG_HAVE_CLKSRC_QCOM) := 0x00208000
> textofs-$(CONFIG_ARCH_AXXIA) := 0x00308000
>
> # Machine directory name. This list is sorted alphanumerically
> diff --git a/arch/arm/mach-qcom/Kconfig b/arch/arm/mach-qcom/Kconfig
> index 2256cd1e25d1..35a03967d9c2 100644
> --- a/arch/arm/mach-qcom/Kconfig
> +++ b/arch/arm/mach-qcom/Kconfig
> @@ -10,6 +10,14 @@ menuconfig ARCH_QCOM
>
> if ARCH_QCOM
>
> +config HAVE_CLKSRC_QCOM
> + bool "Support platforms with qcom clocksource"
> + default y
> + select CLKSRC_QCOM
> + help
> + Select this option if you want to support platforms
> + with the qcom clocksource such as MSM8660 and MSM8960.
Hmm, if we use the option for two things, I think it could use
a different identifier and title, as it seems counterintuitive
to make the text offset based on the clocksource driver.
Is there any common way to classify these, e.g. calling them
'pre-2013 models' or 'Snapdragon S4' as a way to identify them?
The way it appears in Kconfig also still needs to reflect how
this is a subset of the supported platforms (as your current
patch does correctly).
Arnd
next prev parent reply other threads:[~2015-11-25 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 21:04 [PATCH v2 0/3] Remove ARCH_MSM* configs Stephen Boyd
2015-11-25 21:04 ` [PATCH v2 1/3] ARM: qcom: Make an option for qcom clocksource platforms Stephen Boyd
2015-11-25 22:08 ` Arnd Bergmann [this message]
2015-11-25 22:22 ` Stephen Boyd
2015-11-25 22:40 ` Arnd Bergmann
2015-11-25 21:04 ` [PATCH v2 2/3] ARM: qcom_defconfig: Enable HAVE_ARM_ARCH_TIMER Stephen Boyd
2015-11-25 21:04 ` [PATCH v2 3/3] ARM: qcom: Drop ARCH_MSM* configs Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6140735.DAZiajTbh1@wuerfel \
--to=arnd@arndb.de \
--cc=agross@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox