Re: [PATCH 12/25] metag: Add 32 bit time_t and clock_t

Ley Foon Tan
2014-05-13T09:28:10Z

On Tue, May 13, 2014 at 5:22 PM, James Hogan <james.hogan@imgtec.com> wrote:
> Hi,
>
> On 13/05/14 10:04, Ley Foon Tan wrote:
>> Override time_t and clock_t in include/uapi/asm-generic.
>>
>> Signed-off-by: Ley Foon Tan <lftan@altera.com>
>> ---
>> arch/metag/include/asm/Kbuild | 1 -
>> arch/metag/include/uapi/asm/Kbuild | 1 +
>> arch/metag/include/uapi/asm/posix_types.h | 17 +++++++++++++++++
>> 3 files changed, 18 insertions(+), 1 deletion(-)
>> create mode 100644 arch/metag/include/uapi/asm/posix_types.h
>>
>> diff --git a/arch/metag/include/asm/Kbuild b/arch/metag/include/asm/Kbuild
>> index c29ead8..5a97e0d6 100644
>> --- a/arch/metag/include/asm/Kbuild
>> +++ b/arch/metag/include/asm/Kbuild
>> @@ -31,7 +31,6 @@ generic-y += param.h
>> generic-y += pci.h
>> generic-y += percpu.h
>> generic-y += poll.h
>> -generic-y += posix_types.h
>> generic-y += preempt.h
>> generic-y += scatterlist.h
>> generic-y += sections.h
>> diff --git a/arch/metag/include/uapi/asm/Kbuild b/arch/metag/include/uapi/asm/Kbuild
>> index 84e09fe..1542689 100644
>> --- a/arch/metag/include/uapi/asm/Kbuild
>> +++ b/arch/metag/include/uapi/asm/Kbuild
>> @@ -3,6 +3,7 @@ include include/uapi/asm-generic/Kbuild.asm
>>
>> header-y += byteorder.h
>> header-y += ech.h
>> +header-y += posix_types.h
>
> I don't think you need this. The file
> include/uapi/asm-generic/Kbuild.asm which is included at the top of each
> arches uapi/asm/Kbuild already has it.
> (Admittedly there's already a lot of duplication of these that should
> probably be fixed at some point).
>
> Other than that it looks okay to me.
Okay, will remove this.

Thanks.
Regards
Ley Foon