Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Felipe Balbi
2016-04-26T06:19:32Z

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Hi,

Grygorii Strashko <grygorii.strashko@ti.com> writes:
> Now not all DMA paremters configured properly for "xhci-hcd" platform
> device which is created manually. For example: dma_pfn_offset, dam_ops
> and iommu configuration will not corresponds "dwc3" devices
> configuration. As result, this will cause problems like wrong DMA
> addresses translation on platforms with LPAE enabled like Keystone 2.
>
> When platform is using DT boot mode the DMA configuration will be
> parsed and applied from DT, so, to fix this issue, reuse
> of_dma_configure() API and retrieve DMA configuartion for "xhci-hcd"
> from DWC3 device node.

patch is incomplete. You left out non-DT users which might suffer from
the same problem.

--
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]