Re: [PATCH] usb: dwc3: host: inherit dma configuration from parent dev

Russell King - ARM Linux
2016-04-28T14:16:31Z

On Thu, Apr 28, 2016 at 09:37:08AM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Arnd Bergmann <arnd@arndb.de> writes:
> > pointer and pass that in platform_data. This is really easy, it's
>
> Sorry but passing a struct device pointer in platform_data is
> ridiculous. Not to mention that, as I said before, we can't assume which
> device to pass to xhci_plat in the first place. It might be dwc->dev and
> it might be dwc->dev->parent.

+1. Passing an unref-counted struct device through platform data is
totally mad, Arnd you're off your rocker if you think that's a good
idea. What's more is that there's no way to properly refcount the
thing.

--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.