[PATCH 01/10] hwmon: (amc6821) Stop accepting invalid pwm values

Guenter Roeck
2024-06-28T15:13:55Z

The pwm value range is well defined from 0..255. Don't accept
any values outside this range.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/amc6821.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index 9b02b304c2f5..3c614a0bd192 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -360,8 +360,11 @@ static ssize_t pwm1_store(struct device *dev,
if (ret)
return ret;

+ if (val < 0 || val > 255)
+ return -EINVAL;
+
mutex_lock(&data->update_lock);
- data->pwm1 = clamp_val(val , 0, 255);
+ data->pwm1 = val;
i2c_smbus_write_byte_data(client, AMC6821_REG_DCY, data->pwm1);
mutex_unlock(&data->update_lock);
return count;
@@ -558,13 +561,16 @@ static ssize_t pwm1_auto_point_pwm_store(struct device *dev,
struct amc6821_data *data = dev_get_drvdata(dev);
struct i2c_client *client = data->client;
int dpwm;
- long val;
- int ret = kstrtol(buf, 10, &val);
+ unsigned long val;
+ int ret = kstrtoul(buf, 10, &val);
if (ret)
return ret;

+ if (val > 255)
+ return -EINVAL;
+
mutex_lock(&data->update_lock);
- data->pwm1_auto_point_pwm[1] = clamp_val(val, 0, 254);
+ data->pwm1_auto_point_pwm[1] = val;
if (i2c_smbus_write_byte_data(client, AMC6821_REG_DCY_LOW_TEMP,
data->pwm1_auto_point_pwm[1])) {
dev_err(&client->dev, "Register write error, aborting.\n");
--
2.39.2