The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tianchen Ding <dtcccc@linux.alibaba.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Madadi Vineeth Reddy <vineethr@linux.ibm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Josh Don <joshdon@google.com>,
	"open list:SCHEDULER" <linux-kernel@vger.kernel.org>,
	Abel Wu <wuyun.abel@bytedance.com>
Subject: Re: [PATCH 2/2] sched/fair: Fix premature check of WAKEUP_PREEMPTION
Date: Tue, 25 Feb 2025 14:56:52 +0800	[thread overview]
Message-ID: <61589e0e-a3d7-490c-8bba-a1ce25f585c3@linux.alibaba.com> (raw)
In-Reply-To: <CAKfTPtBL4aPbEDOa8jJ+h2wQ9CLU80=0mQdrc07vfqBVswzAsg@mail.gmail.com>



On 2/24/25 9:47 PM, Vincent Guittot wrote:
[...]
> 
> Or we should just remove it. I'm curious to know who used it during
> the last couple of years ? Having in mind that lazy preemption adds
> another level as check_preempt_wakeup_fair()  uses it so sched-idle
> tasks might not always be immediately preempted anyway.
> 

I just remembered that I've mentioned this issue in another thread[1] 
before. Can we do preempt SCHED_IDLE immediately even in PREEMPT_LAZY? (to 
achieve better response time for SCHED_NORMAL)

[1] 
https://lore.kernel.org/all/8e6f02a0-2bd0-4e75-9055-2cb7c508ce4e@linux.alibaba.com/

  parent reply	other threads:[~2025-02-25  6:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 11:12 [PATCH 0/2] Fix SCHED_IDLE behavior on wakeup preemption Abel Wu
2025-02-21 11:12 ` [PATCH 1/2] sched/fair: Do not let idle entities preempt others Abel Wu
2025-02-21 11:48   ` Vincent Guittot
2025-02-21 19:54   ` Josh Don
2025-02-22 17:12   ` Madadi Vineeth Reddy
2025-02-22 17:48   ` Madadi Vineeth Reddy
2025-02-23  8:45     ` Abel Wu
2025-02-21 11:12 ` [PATCH 2/2] sched/fair: Fix premature check of WAKEUP_PREEMPTION Abel Wu
2025-02-21 11:49   ` Vincent Guittot
2025-02-21 15:57     ` Abel Wu
2025-02-22 18:16       ` Madadi Vineeth Reddy
2025-02-23  8:44         ` Abel Wu
2025-02-23 10:25           ` Madadi Vineeth Reddy
2025-02-23 11:22             ` Abel Wu
2025-02-24 13:47               ` Vincent Guittot
2025-02-24 14:10                 ` Phil Auld
2025-02-25 17:14                   ` Vincent Guittot
2025-02-25  6:29                 ` Abel Wu
2025-02-25 17:15                   ` Vincent Guittot
2025-02-26  7:34                     ` Abel Wu
2025-02-25  6:56                 ` Tianchen Ding [this message]
2025-02-24 13:22           ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61589e0e-a3d7-490c-8bba-a1ce25f585c3@linux.alibaba.com \
    --to=dtcccc@linux.alibaba.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=joshdon@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vineethr@linux.ibm.com \
    --cc=vschneid@redhat.com \
    --cc=wuyun.abel@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox