RE: [PATCH] rtw89: fix error function parameter

Pkshih
2021-10-19T05:21:45Z

> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Tuesday, October 19, 2021 11:53 AM
> To: kvalo@codeaurora.org
> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal
> Robot <zealci@zte.com.cn>
> Subject: [PATCH] rtw89: fix error function parameter
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING possible condition with no effect (if == else)
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>

Thanks for the catch.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -753,11 +753,11 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
> if (is_2g)
> rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
> B_P1_MODE_SEL,
> 1, phy_idx);
> else
> rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
> B_P1_MODE_SEL,
> - 1, phy_idx);
> + 0, phy_idx);
> /* SCO compensate FC setting */
> sco_comp = rtw8852a_sco_mapping(central_ch);
> rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1