public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Li, Aubrey" <aubrey.li@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@redhat.com, peterz@infradead.org, hpa@zytor.com,
	ak@linux.intel.com, tim.c.chen@linux.intel.com,
	dave.hansen@intel.com, arjan@linux.intel.com,
	aubrey.li@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time
Date: Tue, 12 Feb 2019 21:20:36 +0800	[thread overview]
Message-ID: <61791002-0928-fa79-8cba-9625eb0418dd@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1902121358050.3710@nanos.tec.linutronix.de>

On 2019/2/12 21:03, Thomas Gleixner wrote:
> On Tue, 12 Feb 2019, Aubrey Li wrote:
> 
> arch/x86/kernel/fpu/xstate.c:1252:6: warning: no previous prototype for ‘avx512_status’ [-Wmissing-prototypes]
>  void avx512_status(struct seq_file *m, struct task_struct *task)
>       ^~~~~~~~~~~~~
Sorry for this warning, I didn't see it on my side. May I know how to open this knob?

> arch/x86/kernel/fpu/xstate.c: In function ‘avx512_status’:
> arch/x86/kernel/fpu/xstate.c:1254:44: error: ‘struct fpu’ has no member named ‘avx512_timestamp’
>   unsigned long timestamp = task->thread.fpu.avx512_timestamp;

I didn't include the first patch, because I saw it's already in tip tree. Did you use tip tree?

>                                             ^
> arch/x86/kernel/fpu/xstate.c: At top level:
> arch/x86/kernel/fpu/xstate.c:1279:6: warning: no previous prototype for ‘arch_proc_pid_status’ [-Wmissing-prototypes]
>  void arch_proc_pid_status(struct seq_file *m, struct task_struct *task)
>       ^~~~~~~~~~~~~~~~~~~~
Sorry for this, May I know how to replicate it on my side?

Thanks,
-Aubrey

  reply	other threads:[~2019-02-12 13:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12  4:49 [PATCH v10 1/3] /proc/pid/status: Add support for architecture specific output Aubrey Li
2019-02-12  4:49 ` [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time Aubrey Li
2019-02-12 13:03   ` Thomas Gleixner
2019-02-12 13:20     ` Li, Aubrey [this message]
2019-02-12 13:24       ` Thomas Gleixner
2019-02-12 13:27         ` Thomas Gleixner
2019-02-12 13:51         ` Li, Aubrey
2019-02-12 13:54           ` Thomas Gleixner
2019-02-12  4:49 ` [PATCH v10 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms Aubrey Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61791002-0928-fa79-8cba-9625eb0418dd@linux.intel.com \
    --to=aubrey.li@linux.intel.com \
    --cc=ak@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=aubrey.li@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox