From: Arnd Bergmann <arnd@arndb.de>
To: John Garry <john.garry@huawei.com>
Cc: James.Bottomley@hansenpartnership.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linuxarm@huawei.com, zhangfei.gao@linaro.org,
linux-scsi@vger.kernel.org, xuwei5@hisilicon.com,
john.garry2@mail.dcu.ie, hare@suse.de
Subject: Re: [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code
Date: Tue, 13 Oct 2015 14:47:19 +0200 [thread overview]
Message-ID: <6185166.M64gFmBG3u@wuerfel> (raw)
In-Reply-To: <561CFCAA.8030003@huawei.com>
On Tuesday 13 October 2015 13:44:26 John Garry wrote:
> Hello,
>
> Just to be clear, are you saying that you would prefer hisi_sas_probe()
> and struct hisi_sas_driver to be relocated to hisi_sas_v1_hw.c?
Correct.
> I wanted to keep hisi_sas_v1_hw.c containing only code which accesses HW.
>
> I could consoldate the calls of hw_init_v1_hw(), interrupt_init_v1_hw(),
> interrupt_openall_v1_hw(), and phys_init_v1_hw() to a single function hw
> init function call. Then most of the code in the probe function will not
> be specific to v1.
This is more about correct layering of the code. Generally we want the
more specific modules on top to call into the more general code in
the bottom of the stack. Shared code should know as little as possible
about the specific implementations it is shared with.
Arnd
next prev parent reply other threads:[~2015-10-13 12:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1444663237-238302-1-git-send-email-john.garry@huawei.com>
[not found] ` <1444663237-238302-6-git-send-email-john.garry@huawei.com>
2015-10-12 15:15 ` [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools Arnd Bergmann
2015-10-13 9:42 ` zhangfei
[not found] ` <1444663237-238302-5-git-send-email-john.garry@huawei.com>
2015-10-12 15:21 ` [PATCH 04/25] scsi: hisi_sas: add scsi host registration Arnd Bergmann
2015-10-13 9:16 ` John Garry
2015-10-13 12:18 ` Arnd Bergmann
[not found] ` <1444663237-238302-8-git-send-email-john.garry@huawei.com>
2015-10-12 15:21 ` [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW Arnd Bergmann
2015-10-13 9:47 ` zhangfei
2015-10-13 12:20 ` Arnd Bergmann
2015-10-13 15:09 ` zhangfei
[not found] ` <1444663237-238302-13-git-send-email-john.garry@huawei.com>
2015-10-12 18:46 ` [PATCH 12/25] scsi: hisi_sas: add v1 HW initialisation code Arnd Bergmann
2015-10-13 12:44 ` John Garry
2015-10-13 12:47 ` Arnd Bergmann [this message]
[not found] ` <1444663237-238302-14-git-send-email-john.garry@huawei.com>
2015-10-16 12:55 ` [PATCH 13/25] scsi: hisi_sas: add path from phyup irq to SAS framework Arnd Bergmann
2015-10-16 13:29 ` John Garry
2015-10-16 13:36 ` Arnd Bergmann
2015-10-19 14:11 ` John Garry
2015-10-19 14:26 ` Arnd Bergmann
2015-10-19 14:55 ` John Garry
2015-10-20 8:40 ` Arnd Bergmann
2015-10-20 9:09 ` John Garry
2015-10-19 8:47 ` [PATCH 00/25] HiSilicon SAS driver John Garry
2015-10-19 8:55 ` Hannes Reinecke
2015-10-19 10:40 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6185166.M64gFmBG3u@wuerfel \
--to=arnd@arndb.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=devicetree@vger.kernel.org \
--cc=hare@suse.de \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox