From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbbBMOaq (ORCPT ); Fri, 13 Feb 2015 09:30:46 -0500 Received: from mail-we0-f177.google.com ([74.125.82.177]:55720 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752303AbbBMOap convert rfc822-to-8bit (ORCPT ); Fri, 13 Feb 2015 09:30:45 -0500 From: Gabriele Mazzotta To: Pali =?ISO-8859-1?Q?Roh=E1r?= Cc: mjg59@srcf.ucam.org, dvhart@infradead.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, A.Sloman@cs.bham.ac.uk, computersforpeace@gmail.com Subject: Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS Date: Fri, 13 Feb 2015 15:30:42 +0100 Message-ID: <6193126.UlCB3asGVW@xps13> In-Reply-To: <201502101036.21896@pali> References: <1421244357-31103-1-git-send-email-gabriele.mzt@gmail.com> <201502101036.21896@pali> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 February 2015 10:36:21 Pali Rohár wrote: > On Wednesday 14 January 2015 15:05:57 Gabriele Mazzotta wrote: > > The ambient light sensor doesn't act like an input trigger, so > > it has to be kept separate. The sensor readings are used to > > determine whether the conditions to change the keyboard > > illumination are satisfied or not the moment an input trigger > > is used. Ambient light changes alone can't change the > > keyboard backlight illumination and don't restart the timer. > > > > Signed-off-by: Gabriele Mazzotta > > --- > > Gabriele, can you look and integrate this patch into full > keyboard backlight support? Ideally send new full one... I will do that soon. Darren, do you prefer one single patch or should I send Pali's patch and my changes in different patches (that can be later squashed) to make the review easier?