From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755346AbdJIRSz (ORCPT ); Mon, 9 Oct 2017 13:18:55 -0400 Received: from mail-he1eur01on0133.outbound.protection.outlook.com ([104.47.0.133]:15776 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754386AbdJIRSw (ORCPT ); Mon, 9 Oct 2017 13:18:52 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=stephend@adiengineering.com; Reply-To: stephend@adiengineering.com Subject: Re: [PATCH] i2c: ismt: Separate I2C block read from SMBus block read From: Stephen Douthit To: Wolfram Sang , Pontus Andersson Cc: Seth Heasley , Neil Horman , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171002124519.GA13496@leonis.localdomain> <20171005124133.7ue727bib2mlpnyy@ninjato> <20171005141311.GA8565@leonis.localdomain> <20171007081426.inlxjb4zevybkai6@ninjato> Organization: ADI Engineering Message-ID: <61adc1fb-ecb2-7164-ded3-b45cb7d570b5@adiengineering.com> Date: Mon, 9 Oct 2017 13:18:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [96.82.2.57] X-ClientProxiedBy: MWHPR1201CA0017.namprd12.prod.outlook.com (2603:10b6:301:4a::27) To VI1PR04MB1360.eurprd04.prod.outlook.com (2a01:111:e400:5348::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be5e443c-8f63-4dd1-e438-08d50f39cdb2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR04MB1360; X-Microsoft-Exchange-Diagnostics: 1;VI1PR04MB1360;3:QmJcgvPt18qm88FjTwz4ZOrGO8hqkcjvHjVEeHj5/0C1Rl5wGOJvP1gjaJpG+oXKSfATIIjjLgmd7DCAZjEVZeLE329XX0QzGQUjI1fe5voohXlmj3LKBLnMAd14Th5zY+w4AKqvNO23uBDaPPlKa/Twodsi9PMCDl9oiROoVCulCv4tetbPNRoDRdxwsQIafmidzIQ2ALtfQX2LdlhtKMDCfssIsx4WLlRbOWNxowWwTnfUqc11djThbsbf1MYr;25:T96+Lac2881uj3Wdd038MqkA6Bo2kLYXcsZtgAf4w3+i+KWALtV40dt/q1PqIl8QAOhRPSUyraMgev2aKReXxQCjrCTs2Ofhy9AQmPxM2IG+CjZ4zgH9At6iS+3H/w+r5fMsfWLAAGuoOXX8X5h8kG8T3wSKhEmvT8tvYoV9WPzVZbmreD83hAzXIWVPxOPLk9/zyPMsY/SM3mt5Ve3UDeNUo0TFO91gRwxbZGYR8Ssp7JcA+I1+S2jjlMwGJz4yPkp+w1FjupDJtZUGjeJdVddOLcgauboGj0JoVjzWnBQIN8d70d2qpzs2Vj6cTTZfE5NC0HjLmkjTeim6e0hCmw==;31:fZUaQ6tIBAd2ErfFttY/K+yHNhirs4BQWYwiidV/2j29QRoBohRIC5ON+2lATbB3jI28+LANbGLV0c4ZrRfy2a+sFO3EpSaz194sF+GbVYxvhIdGYMkMeZqXRq4bD46ANd5A7QyStcontBDaRLNk8XIZtbcpVkUknQ/KEfwJN+erq3AQcAIIjLsyFZ3wuezzubbVXhxP+DsIVJh7fLfatHV94AddnmqyrhE2uzsna9o= X-MS-TrafficTypeDiagnostic: VI1PR04MB1360: X-Microsoft-Exchange-Diagnostics: 1;VI1PR04MB1360;20:ILGv9aNRh24UjqL2gGSxQye/7C5nZAE+dDZKuoLwOPS0OGZfdo4yL8fT/8ByTCc6zEuQmWyf8O/8wu1ENwWAvoR07+zCoWAeDnM8d3oNvdXAthNsEplB2XitHRAOrpcuxIDdqhdPcDuAwxw6rSy3etbD2eeKhx649TGZyJLxzTUV7kcNC7zAE7xqyIL9jtXJYQxtyRX6GwoUqPlK4ZROR/ERKvHd52TzFxBGyRRqP9BMbrD4UvQ37QOFI6EreRCj20LijX61LpkPxTbO7kQxicgyN+5v38rmpman5xiKaqxdGI7bsZLBzYeJf5LcNegvi9eEpzIo2uopTc9x6rKASANbp+Q1vxcPqQITvWz7DjMrOHC0yKxHnWvaMlLKkcP6sdEAYGgN06WvYE/CehkBsL8XCPOYR/JeaDJ7fu2OfKniJmtl0libwtUcWXWLqiovtIL0LxNkO595ROQzHrPir2jxmuWeUm5zzgIjo6nyvwEtaB0pOzom6GW2tIjnQlXq;4:uFRB7KhaxfdKj3OQ45mzhq8J0h8VvsvOuLwdsNMLlfn2jK1KWrkLeAcovRmPSzGdiVolRMwmGDG83MVChrb3Xlsm4v/iZ3m+50svFBBiuyGeLOwNjrj+Mb/+V/hYf3MMf9Ik+j+RUbCk1I0aCZTs1dpFNwUjfju61V2fOVgXc43U86XcTLgg/TxShSyEn7znjBi2O4n2d1SyJ3f9KB9gRTgtFJMKMjj3zQhJcwqB+RPa6MeXJYfpalik8gdooJPgZoyXINaqNBAYHl2UTp+2ebE9V+CIkkcHWgXlCZCd+Fs= X-Exchange-Antispam-Report-Test: UriScan:(265634631926514); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR04MB1360;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR04MB1360; X-Forefront-PRVS: 045584D28C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6069001)(39830400002)(346002)(376002)(189002)(199003)(50986999)(54356999)(58126008)(101416001)(43066003)(68736007)(47776003)(25786009)(23746002)(105586002)(6246003)(3846002)(6116002)(33646002)(106356001)(39060400002)(4326008)(31686004)(65826007)(5660300001)(81156014)(81166006)(3450700001)(189998001)(93886005)(64126003)(8936002)(50466002)(2950100002)(6666003)(6486002)(6506006)(229853002)(8676002)(7736002)(478600001)(65806001)(65956001)(66066001)(6512007)(76176999)(316002)(31696002)(2906002)(230700001)(83506001)(97736004)(575784001)(305945005)(53936002)(86362001)(36756003)(16526018)(110136005)(54906003)(505234006);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR04MB1360;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR04MB1360;23:RwMdnDeCKBjNtJnelBbJbafmY478Dkm2o6/lk?= =?Windows-1252?Q?b42lzQRooMHvYTukvGnmsNfQKlkIvEsr6zLbehK64/U7py0/My1lVdga?= =?Windows-1252?Q?EBOlC1CwS+mo44rQyX9ZCimNDPfp9xp8E54yWbVJcVI1+8nwjcxy5USg?= =?Windows-1252?Q?suyG/uEWSsMsrlt6GUNQjpH3pZdc1UahMDqc5SeWJL8LU2ubbin8nbxc?= =?Windows-1252?Q?SsHcEvVttk65d6kIyRCXZ7TzbuYkoL8/M1HBJyZlv+rfNqCIzlZfGCv3?= =?Windows-1252?Q?5jlrLmw6wkObfck3vfzHzmq1vpYZneuSEqf2WZ6OjXvBICCDaPg1xpGn?= =?Windows-1252?Q?DcqRwQV8quloM8cRyggCKwNXmKwNXp+26WKntl5N/roywQKmG/WoUCrY?= =?Windows-1252?Q?UIqrKlae7ur9YpQ+s8bgw8rCSzQn37gGuZW90gf9zrSIVnusGhxyV3kn?= =?Windows-1252?Q?UGVFD6C+vDUjVsCDjQqEs2vJrn48wT+Mx0p+/Q7GY4mfPQBl72h0W0qz?= =?Windows-1252?Q?Fpmgmr7LBXTHaMYwJUoTniPvvIcKbqVpu4tmuY2YTz+XRZWjOeUmR6mi?= =?Windows-1252?Q?ghL7Za6D0OvX08FX9quyszA0cD4SEMQot7o9qm/atUHovzFSNiWTt2nt?= =?Windows-1252?Q?XDqUS2Vz0+FFStIRJr48+8BrXFJzKFM6qH7f/wT+kTTUSQZJF9DaKlfL?= =?Windows-1252?Q?vybCqcxPR7d1J8gT/ffrm2iUyydYI0kgfpohKqhbOva7xxIOXJxmPXvm?= =?Windows-1252?Q?c3tychQNE+61uBbNUNb8dwny11rnD1i3WUpDmwfkEjlOwT0Z9ylGXgz+?= =?Windows-1252?Q?RJ0kuLdcRzgkUjXSSqDbn39RBen09wbtQnDs5e/3FusQFY1X7wPZhlZq?= =?Windows-1252?Q?PpGtD1ZMX/IzGTPt0nM8GxbIn/Yvb5Dt0LWNI3pOK2KWg9pdQobrx1F6?= =?Windows-1252?Q?NqC8Y31BE0uInZakAxsvGzR3mN6jfMrI99R1bMiO/dG/churasSpD1XF?= =?Windows-1252?Q?oOJjYFT4xAGqHSvJ+ChbT7MGIFBUv/EyRNhj0FhFfRx7k02iGokEMoYg?= =?Windows-1252?Q?njKmu0tdyuq/ciiN9Q7FgbZQ4VQ79gybMiJQAtjOi/HMvKB5H8BzFDND?= =?Windows-1252?Q?RYWo6trD0tXGPKKifW9Yutrfa6oRhkUg7SJIjqEXRfECjyMfqvOzVJg/?= =?Windows-1252?Q?Aj69Dowi1ExTQTpdwLv9d5ypvKmxDJ9ti4UAfR61HwqtezDLEIcY4zLQ?= =?Windows-1252?Q?lKAvLvsMGTlxXIfya2VARX16nFGh22o/KkOLgqBiOmp9BpswnyJ27tWq?= =?Windows-1252?Q?eBYr75DQ2+sX5zl8Roj1Z2lQAlBJKHhlsqNq07x+0dzgFWN27z3yLlrF?= =?Windows-1252?Q?qchWjaC7vSU7EubTSwqRIEk2YJTDa3jmpkB2UqR79VKe3SIlhR0YFuoa?= =?Windows-1252?Q?oOEXtx0pbQGk1SC4ZZr9fGr4LUHELCDDBqrwRNFeQM/ULoZ5O0beCiN/?= =?Windows-1252?Q?na+7q1DkBbVKVIkMPRUulROydM+nipFzggGFkrB8jVZfd2nlM9W8yzES?= =?Windows-1252?Q?XfDGPlD1nbmeBgo/xqDBhrY2EjWRTlVB0vq?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR04MB1360;6:lEqWCQ0RnqScOGGP3l6reLeTFc/No+FS0mnQU1kolLGabc+xTriyEmnX0Ag3xF1xQmY43l1ei4/LpvFa1feBnX7xthyYd18nQBSGJOfCSNsKmaw9riLJR+EJ+0dWOmTzKKwSj4EQY20gHUMyjuvAn1EdLibKBvI5QkXsiL4hDsU7UAMmrRAyQEfNZtUd0dp1a51x2mWv5L7txUny72EP0iJ159KoQUL5PglTIwReItVctZtOUxPacnIkuY68/1vyB1nCHtVPEV2XVxe+Tt3O7TbCF3eEEPae3/7TXZAPpNT1uDrb/ZIDIA2eH2wb9NAQ4m9V+D/r36sWFNnBmHukPA==;5:0ezV4ppFvHzbssO0Q7R7K7UWF9djboDo9ojcnHIbzSiQZ6AD3Ym4B8CXfSOAFPw9pRL2XqGb2B94ROwMNCmKDWb9gVZiC/or6glJN7j9P5BjHOnvXMPcdEkKH3b3ryRWXTF5cdt8TVQICItvbeaJng==;24:Cbj5Gh1DNWyC9lommZ1sQItp/vb8j7tu5nd73QwQE8WUzn7lRYbRPyky3uMk3jZMl0SoO92h7GVg0AUhGlrZPvMI/gD41FhHrClN+PnrorM=;7:AvARf/fm9Kj885PwlpCXAqBXxGfG41TvIm4hAn7l6ze6tiUsuJfGbTFOzMPq6P1vsdm7+0+TjR+TTkvAESkUgHPMerWUul/jLI4eDkrpXDbZBOYvhQ2kaDcRD0HGfSVpDDzJBqkzGbLSDyvi0YeLIlTtGcMXNbFRUXl/QMdRrOAKySizVI/xI8pMhYygXQnkISZs2dFHehDfLOKChqp7uDNYFH9LKTbiXwN/OAa4Moc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: adiengineering.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2017 17:18:46.2023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1360 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > So, I'll wait for his tests and then send it to Linus ASAP. I think it > should be in rc5. I've been able to confirm the regression my patch introduced, and the fix from Pontus. Doing a block read of the SPD EEPROM with my patch everything is shifted by a byte: [root@localhost ~]# i2cdump -y 0 0x50 i 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef 00: 13 0b 02 04 21 02 01 03 11 01 08 0a 00 fe 00 69 ????!???????.?.i 10: 78 69 30 69 11 18 81 20 08 3c 3c 00 f0 83 05 80 xi0i??? ?<<.???? 20: 00 00 00 00 00 00 00 00 85 00 00 00 00 00 00 00 ........?....... 30: 00 00 00 00 00 00 00 00 00 00 00 0f 01 23 00 00 ...........??#.. 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 70: 00 00 00 00 80 2c 00 00 00 00 00 00 00 a6 dc 39 ....?,.......??9 80: 4b 53 46 35 31 32 37 32 41 5a 2d 31 47 36 45 31 KSF51272AZ-1G6E1 90: 20 45 31 80 2c 00 00 00 00 00 00 00 00 00 00 00 E1?,........... a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ff ................ b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff 92 ...............? With the patch from Pontus the I2C block read works as expected: [root@localhost ~]# i2cdump -y 0 0x50 i 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef 00: 92 13 0b 02 04 21 02 01 03 11 01 08 0a 00 fe 00 ?????!???????.?. 10: 69 78 69 30 69 11 18 81 20 08 3c 3c 00 f0 83 05 ixi0i??? ?<<.??? 20: 80 00 00 00 00 00 00 00 00 85 00 00 00 00 00 00 ?........?...... 30: 00 00 00 00 00 00 00 00 00 00 00 00 0f 01 23 00 ............??#. 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 70: 00 00 00 00 00 80 2c 00 00 00 00 00 00 00 a6 dc .....?,.......?? 80: 39 4b 53 46 35 31 32 37 32 41 5a 2d 31 47 36 45 9KSF51272AZ-1G6E 90: 31 20 45 31 80 2c 00 00 00 00 00 00 00 00 00 00 1 E1?,.......... a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................ The ipmi_ssif driver still works with this patch, so no issues for SMBus block reads. Tested-by: Stephen Douthit