From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F913309DCC for ; Tue, 6 Jan 2026 09:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767690981; cv=none; b=bc0mWC/lgqWP4akwqn26XN/r14U25Uem9JQf6Plg6yr6g+s+T5qmG0lqEx61Kx1Zr8rJoqp4Mj+nuwRjVqzcLOK6czs1kdUpaifi3JZ+Mej/3h6PI2Jkr14Ouzx/gcojGyo/K9pLckw2oTtd56Yae/yJTr1XqAYZwFChn5nmmDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767690981; c=relaxed/simple; bh=ie1bpc9Rkof32pGQxJ30gOLVwmlHF/yvwRZ2LsTecAY=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=COTRuCcditkeRKYwAiC1F9xaEd2y+Nt4QFD5UvLG5+B6IUhTcv1f1tcfWm3naPCZ848el4fFyVT0rAQMHrAEijAGUk6x4LHC8CVpStbPYec34wzEH83X+0xAPA8edzCEhFbMMinsCzeLSSXpR8JIQFSAzF2tSJ4cfMAqmHmmvZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Cy5x09AB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cy5x09AB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF57CC116C6; Tue, 6 Jan 2026 09:16:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767690980; bh=ie1bpc9Rkof32pGQxJ30gOLVwmlHF/yvwRZ2LsTecAY=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Cy5x09ABCtRAyTb6N9gEUN5BnJgUFAt3c61AD1KcnSs3Z9oVbQAl+lVe5ntF0a9Vp Cq/X/7hF1zIzqOAyJ92MzzW46YbeB3tXvsLA+xnLpvCy/HSgQGLl2LvPQtko4AMLyy YDxbT+UEBpVFz1j9kzdIA/o7YO8FGkNNN3hwUiwipPkMSHtvP/GqC+RBrF6ldS59Mn IGLup8BGFdNXw+2bSC5gQmse9fSHnC6Zl/vgz1MHiIACcSLEGBI1R8UJg9n9i/HEvN ycBKu4JJKPkO3/VcZvefz3aa3j8xsf/5Pg+zmiUb5e0WAPxrcZBn26FYSIOy+OjZ9l sYzcY4FJhXNzA== Message-ID: <61ba9e54-6e08-4140-b070-05fd696afa48@kernel.org> Date: Tue, 6 Jan 2026 17:16:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/5] f2fs: Zero f2fs_folio_state on allocation To: Nanzhe Zhao , Kim Jaegeuk References: <20260105153101.152892-1-nzzhao@126.com> <20260105153101.152892-2-nzzhao@126.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260105153101.152892-2-nzzhao@126.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/5/2026 11:30 PM, Nanzhe Zhao wrote: > f2fs_folio_state is attached to folio->private and is expected to start > with read_pages_pending == 0. However, the structure was allocated from > ffs_entry_slab without being fully initialized, which can leave > read_pages_pending with stale values. > > Allocate the object with __GFP_ZERO so all fields are reliably zeroed at > creation time. > > Signed-off-by: Nanzhe Zhao Reviewed-by: Chao Yu Thanks,