Re: [PATCH 2/3] dt-bindings: i2c: add Novatek NT726xx SoC i2c controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/06/2026 12:37, Krzysztof Kozlowski wrote:
>> +title: Novatek NT726xx SoC I2C master controller
>> +
>> +allOf:
>> +  - $ref: /schemas/i2c/i2c-controller.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    const: novatek,nt726xx-i2c

One more thing - you must have specific compatibles. This is EXPLICITLY
requested in writing bindings. Please carefully read entire file.

>> +
>> +  reg:
>> +    maxItems: 4
> 
> You need to list the items instead.
> 
>> +
>> +  interrupts:
>> +    maxItems: 3
> 
> You need to list the items instead.
> 
>> +
>> +  clock-frequency:
>> +    description: Operation clock frequency of i2c in Hz.
> 
> Drop
> 
>> +    default: 100000
>> +    enum: [ 100000, 400000 ]
>> +
>> +  novatek,hwmods:
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    description: Name of each i2c pin, must be named with "i2cX". (X is
>> +                 an integer starting from 0)
>> +    minItems: 1
> 
> There is no such syntax. Please do not invent own style.
> 
> Anyway, I don't understand the property - drop.
> 
>> +
>> +  novatek,stbc:
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: Set if this i2c master controlled by stbc.
> 
> No clue what does that mean. What is stbc? Acronym of something? Why
> would that be a property of a board?
> 
>> +    minItems: 1
> 
> Please open existing code. Do you see anywhere uint32 with minItems?
> Like anywhere? I really wonder what process lead to such code...


Heh, and now I see you never tested it even before sending it.

Best regards,
Krzysztof