public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
	will@kernel.org, eric.auger@redhat.com, yuzhe@nfschina.com,
	oliver.upton@linux.dev, shan.gavin@gmail.com,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Alexandru Elisei <Alexandru.Elisei@arm.com>
Subject: Re: [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection()
Date: Mon, 26 Sep 2022 09:21:08 +1000	[thread overview]
Message-ID: <61dad836-2c4d-e462-3f52-1524db437629@redhat.com> (raw)
In-Reply-To: <87bkr5hto4.wl-maz@kernel.org>

Hi Marc,

On 9/24/22 9:56 PM, Marc Zyngier wrote:
> Side note: please make sure you always Cc all the KVM/arm64 reviewers
> when sending patches (now added).
> 

Sure. The reason, why I didn't run './scripts/get_maintainer.pl' to get
all reviewers, is the patch is super simple one :)

> On Fri, 23 Sep 2022 07:54:47 +0100,
> Gavin Shan <gshan@redhat.com> wrote:
>>
>> The ITS collection is guranteed to be !NULL when update_affinity_collection()
>> is called. So we needn't check ITE's collection with NULL because the
>> check has been included to the later one.
> 
> It took me a while to understand what you meant by this: the 'coll'
> parameter to update_affinity_collection() is never NULL, so comparing
> it with 'ite->collection' is enough to cover both the NULL case and
> the "another collection" case.
> 
> If you agree with this, I can directly fix the commit message when
> applying the patch.
> 

Yes, the commit message is accurate and correct. Please help to apply
your commit message directly :)

Thanks,
Gavin


  reply	other threads:[~2022-09-25 23:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23  6:54 [PATCH] KVM: arm64: vgic: Remove duplicate check in update_affinity_collection() Gavin Shan
2022-09-24 11:56 ` Marc Zyngier
2022-09-25 23:21   ` Gavin Shan [this message]
2022-09-26  9:45     ` Marc Zyngier
2022-09-26  9:59 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61dad836-2c4d-e462-3f52-1524db437629@redhat.com \
    --to=gshan@redhat.com \
    --cc=Alexandru.Elisei@arm.com \
    --cc=eric.auger@redhat.com \
    --cc=james.morse@arm.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=shan.gavin@gmail.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzhe@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox