From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
"Ricardo B. Marliere" <rbmarliere@gmail.com>,
<joonas.lahtinen@linux.intel.com>, <rodrigo.vivi@intel.com>,
<tvrtko.ursulin@linux.intel.com>, <airlied@gmail.com>,
<daniel@ffwll.ch>, <John.C.Harrison@Intel.com>,
<alan.previn.teres.alexis@intel.com>,
<harshit.m.mogalapalli@oracle.com>, <michal.wajdeczko@intel.com>,
<gregkh@linuxfoundation.org>
Cc: <intel-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<skhan@linuxfoundation.org>
Subject: Re: [PATCH] gpu: drm: i915: fix documentation style
Date: Mon, 21 Aug 2023 14:00:40 -0700 [thread overview]
Message-ID: <61fa76d7-537e-29d0-b9d8-1b19f05d2ffc@intel.com> (raw)
In-Reply-To: <87il9874cz.fsf@intel.com>
On 8/21/2023 9:22 AM, Jani Nikula wrote:
> On Mon, 21 Aug 2023, "Ricardo B. Marliere" <rbmarliere@gmail.com> wrote:
>> This patch fixes the following sphinx warnings in the htmldocs make target:
>>
>> Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: ERROR: Unexpected indentation.
>> Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:30: WARNING: Block quote ends without a blank line; unexpected unindent.
>> Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:35: WARNING: Bullet list ends without a blank line; unexpected unindent.
>>
>> Signed-off-by: Ricardo B. Marliere <rbmarliere@gmail.com>
> Already fixed by commit 175b036472f6 ("drm/i915: fix Sphinx indentation
> warning") in drm-next.
Should we send this commit through the -fixes path, so it gets included
in 6.5?
Daniele
> BR,
> Jani.
>
>> ---
>> drivers/gpu/drm/i915/gt/uc/intel_huc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
>> index ddd146265beb..fa70defcb5b2 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
>> @@ -26,6 +26,7 @@
>> * The kernel driver is only responsible for loading the HuC firmware and
>> * triggering its security authentication. This is done differently depending
>> * on the platform:
>> + *
>> * - older platforms (from Gen9 to most Gen12s): the load is performed via DMA
>> * and the authentication via GuC
>> * - DG2: load and authentication are both performed via GSC.
>> @@ -33,6 +34,7 @@
>> * not-DG2 older platforms), while the authentication is done in 2-steps,
>> * a first auth for clear-media workloads via GuC and a second one for all
>> * workloads via GSC.
>> + *
>> * On platforms where the GuC does the authentication, to correctly do so the
>> * HuC binary must be loaded before the GuC one.
>> * Loading the HuC is optional; however, not using the HuC might negatively
next prev parent reply other threads:[~2023-08-21 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 15:02 [PATCH] gpu: drm: i915: fix documentation style Ricardo B. Marliere
2023-08-21 16:22 ` Jani Nikula
2023-08-21 21:00 ` Ceraolo Spurio, Daniele [this message]
2023-08-22 21:50 ` Vivi, Rodrigo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61fa76d7-537e-29d0-b9d8-1b19f05d2ffc@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=John.C.Harrison@Intel.com \
--cc=airlied@gmail.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wajdeczko@intel.com \
--cc=rbmarliere@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=skhan@linuxfoundation.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox