From: Lu Baolu <baolu.lu@linux.intel.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>,
dwmw2@infradead.org, will@kernel.org, joro@8bytes.org
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, arei.gonglei@huawei.com
Subject: Re: [PATCH v2 1/2] iommu/vt-d: convert the return type of first_pte_in_page to bool
Date: Thu, 7 Oct 2021 14:18:15 +0800 [thread overview]
Message-ID: <62016e41-5d9d-2d42-e16f-59809f9f1f75@linux.intel.com> (raw)
In-Reply-To: <20211005152308.1061-2-longpeng2@huawei.com>
On 2021/10/5 23:23, Longpeng(Mike) wrote:
> first_pte_in_page() returns boolean value, so let's convert its
> return type to bool.
>
> Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
> ---
> include/linux/intel-iommu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
> index 05a65eb..a590b00 100644
> --- a/include/linux/intel-iommu.h
> +++ b/include/linux/intel-iommu.h
> @@ -708,7 +708,7 @@ static inline bool dma_pte_superpage(struct dma_pte *pte)
> return (pte->val & DMA_PTE_LARGE_PAGE);
> }
>
> -static inline int first_pte_in_page(struct dma_pte *pte)
> +static inline bool first_pte_in_page(struct dma_pte *pte)
> {
> return !((unsigned long)pte & ~VTD_PAGE_MASK);
> }
>
Probably,
return IS_ALIGNED((unsigned long)pte, VTD_PAGE_SIZE);
looks neater?
Best regards,
baolu
next prev parent reply other threads:[~2021-10-07 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 15:23 [PATCH v2 0/2] iommu/vt-d: boost the mapping process Longpeng(Mike)
2021-10-05 15:23 ` [PATCH v2 1/2] iommu/vt-d: convert the return type of first_pte_in_page to bool Longpeng(Mike)
2021-10-07 6:18 ` Lu Baolu [this message]
2021-10-07 11:43 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-10-05 15:23 ` [PATCH v2 2/2] iommu/vt-d: avoid duplicated removing in __domain_mapping Longpeng(Mike)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62016e41-5d9d-2d42-e16f-59809f9f1f75@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=arei.gonglei@huawei.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox