From: Markus Elfring <Markus.Elfring@web.de>
To: Zide Chen <zide.chen@intel.com>,
linux-perf-users@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
Eranian Stephane <eranian@google.com>,
Ian Rogers <irogers@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>
Cc: lkp@intel.com, LKML <linux-kernel@vger.kernel.org>,
Thomas Falcon <thomas.falcon@intel.com>,
Xudong Hao <xudong.hao@intel.com>
Subject: Re: [PATCH] perf/x86/intel/uncore: Fix iounmap() leak on global_init failure
Date: Tue, 13 Jan 2026 17:21:26 +0100 [thread overview]
Message-ID: <6213d28c-7377-44c2-92c6-0dc34cfdf60a@web.de> (raw)
In-Reply-To: <20260113002539.408943-1-zide.chen@intel.com>
> If domain->global_init() fails in __parse_discovery_table(), the
> mapped MMIO region is not released before returning, resulting in
> an iounmap() leak.
How do you think about to avoid a bit of duplicate source code here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19-rc5#n526
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n94
Regards,
Markus
next prev parent reply other threads:[~2026-01-13 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 0:25 [PATCH] perf/x86/intel/uncore: Fix iounmap() leak on global_init failure Zide Chen
2026-01-13 0:48 ` Mi, Dapeng
2026-01-13 16:21 ` Markus Elfring [this message]
2026-01-13 22:04 ` Chen, Zide
2026-01-14 7:25 ` Markus Elfring
2026-01-14 7:51 ` Markus Elfring
2026-01-14 19:41 ` Chen, Zide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6213d28c-7377-44c2-92c6-0dc34cfdf60a@web.de \
--to=markus.elfring@web.de \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
--cc=xudong.hao@intel.com \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox