From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754840AbcGFNma (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jul 2016 09:42:30 -0400
Received: from mout.kundenserver.de ([212.227.126.135]:49882 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754414AbcGFNm3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jul 2016 09:42:29 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Fabio Estevam <festevam@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: imx21: include linux/module.h
Date: Wed, 06 Jul 2016 15:45:31 +0200
Message-ID: <6230401.JFgrqYCo0I@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <20160706132139.GE26134@windriver.com>
References: <20160706125254.1663066-1-arnd@arndb.de> <CAOMZO5APrVUAi+QbnLVJ61T_oJRQQDF_eLi8_HeqK=L+aVBzwQ@mail.gmail.com> <20160706132139.GE26134@windriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:lNnWCsA3sZxOwgjTHRwwhKpR+EkAS3ydG2CaNTJKczW2cKzxsUm
 iUT0SLY2KGSVziMWiciYe0k85a7jQJXCMC9/WBksvb+1VCy1hjPDt5tLS/qKwMiumxjmGwS
 H9S/HozDfSYCO97dhmxj6JssRitcTvpGV6D9yqq0EKnb+vZ1qgbUzTdg1UQDr+yOWgIJjs6
 f28a7TRYUlSnVxliwAPAQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:yEefi7RWRRc=:Cfvjr3wwpoVE3/cJ2+wsKN
 ATeKs8i6Ee0udOEhtlTEESkQWgsoXVKYghY49m+hfftiOUkpg7l24nolqVK6WL4ELzE8g5Z72
 gj3uwRUMxfivPRGv9Zrl6yozEEMDVVQe2YZlV3NlcsZskJi16/jFwEyBJ7KNKE/kgqaxcgiAq
 D8cvjyhYcg+Om9ynh0jiKjkq8vZtNwyuKHTRmwqdZJT6VSLpfh9NO0+h1T/aC6Ur293L3RkQK
 1zKf0dMx1c+4aMgmHKkZpKis3xg8KfWSnRj3eugzFvi725JOVvSKn6HbxXzZEixqraisSJMaJ
 PctjyeoIyWy5/2uX/JM/7Q7RJKgeGoZ8jfJWKXlsCyf61beVUtl1CopB4x0XextYUr2tTSX/u
 qFIXOdIKbPA8xo6Jany8vUeINetlpp6u7G0DoTE97H9yUFjWoXLzIfXH9hjBd+VcUAKDHC/rd
 kayX4oIX6luBebKyyfmDCecMNfrgQGS5bu80kPJH7CWM/expn4ZcnP9uwKO2raDaKa8Qu91/n
 IpRJhcWjqtB3/j+PxoPz6gj7EG0yfO3u0Bn1cBboTK/ZRW2k8V5vA077LBnKb44dGn3ctaAbC
 /Lh/bFfQHmVYIDvwRCtunStW3L7O4Vtuo3pFUjZVn8Inyz2by0dD8eaUlgtc/+V7YqcVbZ6J7
 Qi4ZMJ2WzoO3kl7r4D2aMwjgAkhBpG1TIlHvr1OAEz+QAPTWv6tPXyspyuNfnROTL4xi13hzn
 KTzs9xsw29zCiOKy
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, July 6, 2016 9:21:39 AM CEST Paul Gortmaker wrote:
> > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> > @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] =
> >         { .compatible = "fsl,imx21-iomuxc", },
> >         { }
> >  };
> > -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> > 
> >  static struct platform_driver imx21_pinctrl_driver = {
> >         .driver = {
> > 
> > 
> > If you agree I can send a formal patch.
> 
> Yes, deleting the MODULE_DEVICE_TABLE is the right fix.  I'm curious why
> that never showed up in all the build coverage I did...

I needed several hundred randconfig builds before hitting it, I think
it's just rare because the driver is not enabled most of the time, and
it's possible that the header sometimes gets included implicitly.

	Arnd