From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FE0B1E520F for ; Tue, 27 May 2025 13:41:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748353290; cv=none; b=GCOnsPe4hSp9ud7w+m7aKcbW7OqUobtMasS2qSHmWy6GU2J83Rih2gWhhCoWqTfhI5opwx+mNE3ro82xr16dOo14gENAZFeAO3Upig9dmBw6RXJvOoS4kx05GsV0a6fxmi4huxleeTrkAWaIuONbz+wOdGUHgG5g4qnPFb/QdeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748353290; c=relaxed/simple; bh=eqrnG1lZLmsW/y+K5POXZAg471BAsSXO8VWTa+x9WEs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jShvJMAVMX7rYBuJ9ZbSwf3bjMMKLM1Q22ZiYyLuroOkuNONBfpl//Qtj8VsQCuUUAXpn5N0sLGX0+u+KkqWCKacscC7mI8SKyM3hkx0O9IhdbnBaRDohp1eGTwF/s2wU1AJshVEHlr6cP8ss9d9cm3gJRHQ5reRzstAxZY68Lo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oz/1jUbP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oz/1jUbP" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54RB0TQY010930 for ; Tue, 27 May 2025 13:41:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ERfDT1p+bjimwu7UE0keI/XkAbZ8gsveAmakce5jzjU=; b=oz/1jUbPk71hvr8K SFvCeOgzjdmvLzpWF5DGRXrCI1Wkf1QkebuvBPown1H0wI+2+Z5vwPCtDRKgODh1 ZDLNmWMe4rLs73oNP0yjjNtXe2tHECwOkY4Xhv2RqKfQY1drp7LDeyBYatYjrx/U UOJwmJBz+iPqAK62OARQnW8VgLTuamI/Hc0UcgusEKB08yGbZ9fPBZ/QBZ+yjRLY IFc7SCPJjoHY0ibauyYXqvlMuubxE1jYgOQjv2MZcdilvYyXCfKnEDU1T6104lqF PEBte9UI/YyLHAftW17MAmMHXA4PBQlFcQL7Gj2Ir9I42yW1hl4HLWmTtHk7IOvt Ms45hQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46u549f19y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 27 May 2025 13:41:27 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6faa4e69621so4634636d6.1 for ; Tue, 27 May 2025 06:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748353287; x=1748958087; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ERfDT1p+bjimwu7UE0keI/XkAbZ8gsveAmakce5jzjU=; b=EiC/mQ2KPTXsxY+/nyKa3VfzbGmv5LB7r3JfCR+lWlmpxP9DLCXDHyHA/+wBn1qpZ5 Vknf6npwzmJDGhFJGqEUAA1fUYOgz2hIRySFcIrb/pHOW8aMCbVuaZs+W/3Y+Tw2tGYJ cttOlHG2/6hOFU+1O92QwUZPrcOvG1nyews4wk/9JskJgFWAJQ/68t8axlqPgk+OyFqz ATC9fyrBNLcGIAX3NZCwyabaf33QC4GTlYT7kU6FqEnQI7Gk18zDR5BvQFjnFuS06d8q YliDs3VpOYxZzWTAj+8A5ZU8Mq3pUuiEpfVuMCn5IDcDCnEPTgVyOZ0rFPHQDjCkCKpD yiSA== X-Forwarded-Encrypted: i=1; AJvYcCVWsLlIn/qG6KrttKp0ju1/o33lwSpdkkXT6HtXne0pkqCdj7Vaaklr6jiS6sNhDbgJzvPNL8/kpuC1Snk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8LpeIxIT5ayH+2iEKclHhuoKewILZfGoV2EqCkB7kuS+Y83Kh 8xhhqjMctI20RO41NdFZpzvQlMxhx7KNfjmEInRQ/MThMtjmsDu48jC5QsldbCR2c1JtFCNAqMc S0Vk/6LnMmjW5zmqXAkOYuaiAyzYer4xe0knC9LfMyjG4PBeLy4LlbptKMOlrXYj0hhE= X-Gm-Gg: ASbGncsNtjTow798UXdvSIyfiP4LuYQkcea3rE6GIU9PhUasd6IkkDXSciIUoYxfS0J gllNECDpTW86okz+XPALP1R78qXz2PP8z3EROpI/Ilm9HSUPfgTIFFramqgsai11DQeDF7lus31 hqeeOtNLhvFcr+JgbhuJpno/oFVFlKalVEAMfrNZOj8birX86gGDSXSuSaJVldTRW9iCO391JMz Hg/oPy3jClzL0vazY5jRb9uuUNVv/N8JiUvta9+f7cDSCHcpMwuVvNiCOn04kmqt2v6nrSg0ae+ pOTGyvSDKyAwPYEzysi6OHFwG1Ff5OnvTFi2thR8PEKHRFcFCLtOPtK2ZsgckIkwLg== X-Received: by 2002:a05:6214:f2c:b0:6f5:4259:297c with SMTP id 6a1803df08f44-6fa9d322aadmr73791366d6.7.1748353287149; Tue, 27 May 2025 06:41:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjqXPi+7vAd88Ft7f9PnA4rmMxmVtVhyeYRYjMeWxtVj3a4v2wV20uTm0Pohz8zd9qMGjP5Q== X-Received: by 2002:a05:6214:f2c:b0:6f5:4259:297c with SMTP id 6a1803df08f44-6fa9d322aadmr73791086d6.7.1748353286612; Tue, 27 May 2025 06:41:26 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60306f0e39esm4940959a12.33.2025.05.27.06.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 06:41:26 -0700 (PDT) Message-ID: <62380db5-5f01-4652-85a3-4dd213deba5c@oss.qualcomm.com> Date: Tue, 27 May 2025 15:41:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: net: qcom,ipa: document qcm2290 compatible To: =?UTF-8?Q?Wojciech_Sle=C5=84ska?= Cc: Krzysztof Kozlowski , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alex Elder , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20241220073540.37631-1-wojciech.slenska@gmail.com> <20241220073540.37631-2-wojciech.slenska@gmail.com> <5bba973b-73fd-4e54-a7c9-6166ab7ed1f0@kernel.org> <939f55e9-3626-4643-ab3b-53557d1dc5a9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 9PIaNOC93kPxKWzNwD6-2TURCF2zvJA5 X-Authority-Analysis: v=2.4 cv=E9nNpbdl c=1 sm=1 tr=0 ts=6835c108 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NEAV23lmAAAA:8 a=pGLkceISAAAA:8 a=Mi87qWPe0p8fJGbmGX4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTI3MDExMSBTYWx0ZWRfXxiARGfChbnIJ GsUmdObD+UP7KuGI5InhecfuBqHn89RC255ZUGKrkvWcKXBoBzEeb07kW4OEIoAi4Tk9KxXiCwb oCE5YsnJE41gKTpYBvk7piOqgS5vKZE+H2bdH/C+oLSViqBptigXD3PRaXvfb0/ROZryoym0onw ty/dOfJMpi21vY8kJSdX0XycPoV5BdQIhQ8vrjfT5H3ZFthwMwU6KOsksIPdsvTwkPUOjeeF0Mn xtJMwxeswcYtGjjAwE6mFptx0KEyhWKcJnAOCBdEqcbF3SC1ew1I6dRgI3U2XJpXGpwO+rdkkSa wxxwNQ6fmFePzvZaTWomiThNnDN3F5h330K+e9kd1+a1MdNAOlev6j+CCz5jkgnaHCrscumo9fy g9IMBPYotEk8YLL025uWg5IISLUwdzqij3uQibFIixJa+CLuBa9lWyPhivFmxODKALDAL6f/ X-Proofpoint-ORIG-GUID: 9PIaNOC93kPxKWzNwD6-2TURCF2zvJA5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-27_06,2025-05-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505270111 On 5/26/25 9:39 PM, Wojciech Sleńska wrote: > pt., 23 maj 2025 o 01:30 Konrad Dybcio > napisał(a): >> >> On 12/21/24 9:44 PM, Krzysztof Kozlowski wrote: >>> On 20/12/2024 08:35, Wojciech Slenska wrote: >>>> Document that ipa on qcm2290 uses version 4.2, the same >>>> as sc7180. >>>> >>>> Signed-off-by: Wojciech Slenska >>>> --- >>>> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml >>>> index 53cae71d9957..ea44d02d1e5c 100644 >>>> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml >>>> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml >>>> @@ -58,6 +58,10 @@ properties: >>>> - enum: >>>> - qcom,sm8650-ipa >>>> - const: qcom,sm8550-ipa >>>> + - items: >>>> + - enum: >>>> + - qcom,qcm2290-ipa >>>> + - const: qcom,sc7180-ipa >>>> >>> We usually keep such lists between each other ordered by fallback, so >>> this should go before sm8550-fallback-list. >>> >>> With that change: >>> >>> Acked-by: Krzysztof Kozlowski >> >> (half a year later) >> >> I've now sent a series that resolves the issue described in the >> other branch of this thread. Feel free to pick up this binding >> Krzysztof/Rob/Kuba. >> >> >> >> Patch 2 will need an update and some prerequisite changes. >> Wojciech, you'll need: >> >> https://lore.kernel.org/linux-arm-msm/20250523-topic-ipa_imem-v1-0-b5d536291c7f@oss.qualcomm.com >> https://lore.kernel.org/linux-arm-msm/20250523-topic-ipa_mem_dts-v1-0-f7aa94fac1ab@oss.qualcomm.com >> https://github.com/quic-kdybcio/linux/commits/topic/ipa_qcm2290 >> >> and a snippet like >> >> -----------o<----------------------------------- >> qcom,smem-state-names = "ipa-clock-enabled-valid", >> "ipa-clock-enabled"; >> >> + sram = <&ipa_modem_tables>; >> + >> status = "disabled"; >> -----------o<----------------------------------- >> >> added to your DT change >> >> please let me know if it works with the above >> >> if you're not interested anymore or don't have the board on hand, >> I can take up your patch, preserving your authorship ofc >> >> Konrad > > Hello Konrad, > > I have applied your patches on top of the 6.15 kernel. > I used the following: > Konrad Dybcio: arm64: dts: qcom: qcm2290: Explicitly describe the IPA IMEM slice > Konrad Dybcio: dt-bindings: sram: qcom,imem: Document QCM2290 IMEM > Konrad Dybcio: net: ipa: Grab IMEM slice base/size from DTS > Konrad Dybcio: dt-bindings: net: qcom,ipa: Add sram property for > describing IMEM slice > Konrad Dybcio: dt-bindings: sram: qcom,imem: Allow modem-tables > Konrad Dybcio: net: ipa: Make the SMEM item ID constant > > Two corrections were needed: > 1. A small change in the DTS: > - reg = <0x0c100000 0x2a000>; > - ranges = <0x0 0x0c100000 0x2a000>; > + reg = <0 0x0c100000 0 0x2a000>; > + ranges = <0 0 0x0c100000 0x2a000>; > > This was necessary because, in the original version, the following line: > ret = of_address_to_resource(ipa_slice_np, 0, res); > returns -22 Ouch! thanks for noticing this and for all the testing Konrad