* [PATCH 4/4] kconfig: remove unused definition from scanner
@ 2013-10-02 5:24 Martin Walch
2013-10-02 6:42 ` Dirk Gouders
0 siblings, 1 reply; 6+ messages in thread
From: Martin Walch @ 2013-10-02 5:24 UTC (permalink / raw)
Cc: Michal Marek, Jiri Kosina, Yann E. MORIN,
Arve Hjønnevåg, Benjamin Poirier, Dirk Gouders,
Wang YanQing, Andrew Morton, Jean Delvare, Kees Cook, Alan Cox,
linux-kbuild, linux-kernel
From: Martin Walch <walch.martin@web.de>
Date: Wed, 2 Oct 2013 06:58:46 +0200
Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
Signed-off-by: Martin Walch <walch.martin@web.de>
---
scripts/kconfig/zconf.l | 1 -
1 file changed, 1 deletion(-)
diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
index 6555a47..1a9f53e 100644
--- a/scripts/kconfig/zconf.l
+++ b/scripts/kconfig/zconf.l
@@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
}
%}
-ws [ \n\t]
n [A-Za-z0-9_]
%%
--
1.8.1.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] kconfig: remove unused definition from scanner
2013-10-02 5:24 [PATCH 4/4] kconfig: remove unused definition from scanner Martin Walch
@ 2013-10-02 6:42 ` Dirk Gouders
2013-10-02 6:57 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Dirk Gouders @ 2013-10-02 6:42 UTC (permalink / raw)
To: Martin Walch
Cc: Michal Marek, Jiri Kosina, Yann E. MORIN,
Arve Hjønnevåg, Benjamin Poirier, Wang YanQing,
Andrew Morton, Jean Delvare, Kees Cook, Alan Cox, linux-kbuild,
linux-kernel
Martin Walch <walch.martin@web.de> writes:
> From: Martin Walch <walch.martin@web.de>
> Date: Wed, 2 Oct 2013 06:58:46 +0200
> Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
>
> The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
Hi Martin,
I think you should also regenerate the scanner and add
the new zconf.lex.c_shipped to this patch.
Dirk
> Signed-off-by: Martin Walch <walch.martin@web.de>
> ---
> scripts/kconfig/zconf.l | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
> index 6555a47..1a9f53e 100644
> --- a/scripts/kconfig/zconf.l
> +++ b/scripts/kconfig/zconf.l
> @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
> }
> %}
>
> -ws [ \n\t]
> n [A-Za-z0-9_]
>
> %%
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] kconfig: remove unused definition from scanner
2013-10-02 6:42 ` Dirk Gouders
@ 2013-10-02 6:57 ` Yann E. MORIN
2013-10-03 0:30 ` Martin Walch
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2013-10-02 6:57 UTC (permalink / raw)
To: Dirk Gouders
Cc: Martin Walch, Michal Marek, Jiri Kosina, Arve Hjønnevåg,
Benjamin Poirier, Wang YanQing, Andrew Morton, Jean Delvare,
Kees Cook, Alan Cox, linux-kbuild, linux-kernel
Martin, All,
On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> Martin Walch <walch.martin@web.de> writes:
>
> > From: Martin Walch <walch.martin@web.de>
> > Date: Wed, 2 Oct 2013 06:58:46 +0200
> > Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
> >
> > The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
>
> Hi Martin,
>
> I think you should also regenerate the scanner and add
> the new zconf.lex.c_shipped to this patch.
I think sending the re-generated parser as a separate patch helps
in reviewing. Ie. I'd prefer a fifth patch.
BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config
Regards,
Yann E. MORIN.
> > Signed-off-by: Martin Walch <walch.martin@web.de>
> > ---
> > scripts/kconfig/zconf.l | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
> > index 6555a47..1a9f53e 100644
> > --- a/scripts/kconfig/zconf.l
> > +++ b/scripts/kconfig/zconf.l
> > @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
> > }
> > %}
> >
> > -ws [ \n\t]
> > n [A-Za-z0-9_]
> >
> > %%
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 4/4] kconfig: remove unused definition from scanner
2013-10-02 6:57 ` Yann E. MORIN
@ 2013-10-03 0:30 ` Martin Walch
2013-10-03 6:37 ` Yann E. MORIN
2013-10-03 13:13 ` Dirk Gouders
0 siblings, 2 replies; 6+ messages in thread
From: Martin Walch @ 2013-10-03 0:30 UTC (permalink / raw)
To: Yann E. MORIN, linux-kbuild
Cc: Dirk Gouders, Michal Marek, Jiri Kosina, Arve Hjønnevåg,
Benjamin Poirier, Wang YanQing, Andrew Morton, Jean Delvare,
Kees Cook, linux-kernel
On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
> On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> > I think you should also regenerate the scanner and add
> > the new zconf.lex.c_shipped to this patch.
>
> I think sending the re-generated parser as a separate patch helps
> in reviewing. Ie. I'd prefer a fifth patch.
>
> BTW, regenerating the parser can be done with:
> make REGENERATE_PARSERS=1 config
Actually, I regenerated the scanner. However, the results did not change
after applying the patch, because the definition that the patch removes
(ws) is not used anywhere. It is only a cleanup.
Regenerating the scanner and the parser code with newer versions of
flex and bison results in code changes. However, they are not related to
the patch, but originate from updates in flex and bison.
Therefore I did not see any point in including the regenerated files in
this patch set.
Of course, if you see any benefit in regenerating the *_shipped files, I can
still do so.
Regards,
Martin Walch
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] kconfig: remove unused definition from scanner
2013-10-03 0:30 ` Martin Walch
@ 2013-10-03 6:37 ` Yann E. MORIN
2013-10-03 13:13 ` Dirk Gouders
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2013-10-03 6:37 UTC (permalink / raw)
To: Martin Walch
Cc: linux-kbuild, Dirk Gouders, Michal Marek, Jiri Kosina,
Arve Hjønnevåg, Benjamin Poirier, Wang YanQing,
Andrew Morton, Jean Delvare, Kees Cook, linux-kernel
Martin, All,
On Thursday 03 October 2013 02:30:21 Martin Walch wrote:
> On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
> > On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> > > I think you should also regenerate the scanner and add
> > > the new zconf.lex.c_shipped to this patch.
> >
> > I think sending the re-generated parser as a separate patch helps
> > in reviewing. Ie. I'd prefer a fifth patch.
> >
> > BTW, regenerating the parser can be done with:
> > make REGENERATE_PARSERS=1 config
>
> Actually, I regenerated the scanner. However, the results did not change
> after applying the patch, because the definition that the patch removes
> (ws) is not used anywhere. It is only a cleanup.
OK, then please say so in the commit message.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/4] kconfig: remove unused definition from scanner
2013-10-03 0:30 ` Martin Walch
2013-10-03 6:37 ` Yann E. MORIN
@ 2013-10-03 13:13 ` Dirk Gouders
1 sibling, 0 replies; 6+ messages in thread
From: Dirk Gouders @ 2013-10-03 13:13 UTC (permalink / raw)
To: Martin Walch
Cc: Yann E. MORIN, linux-kbuild, Michal Marek, Jiri Kosina,
Arve Hjønnevåg, Benjamin Poirier, Wang YanQing,
Andrew Morton, Jean Delvare, Kees Cook, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]
Martin Walch <walch.martin@web.de> writes:
> On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote:
>> On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
>> > I think you should also regenerate the scanner and add
>> > the new zconf.lex.c_shipped to this patch.
>>
>> I think sending the re-generated parser as a separate patch helps
>> in reviewing. Ie. I'd prefer a fifth patch.
>>
>> BTW, regenerating the parser can be done with:
>> make REGENERATE_PARSERS=1 config
>
> Actually, I regenerated the scanner. However, the results did not change
> after applying the patch, because the definition that the patch removes
> (ws) is not used anywhere. It is only a cleanup.
Sorry, my review was too superficial.
I did downgrade my flex to see if your changes affect the scanner,
but I did not test it without your patch and also did not have a look in
what the changes are.
The changes I noticed here are probably related to the flex package I
use (on a Gentoo system) -- they even occur without your patch. I'll
attach what I noticed in case someone is interested.
Dirk
[-- Attachment #2: zconf.lex.c_shipped.patch --]
[-- Type: text/plain, Size: 583 bytes --]
diff --git a/scripts/kconfig/zconf.lex.c_shipped b/scripts/kconfig/zconf.lex.c_shipped
index a0521aa..3eb4c0b 100644
--- a/scripts/kconfig/zconf.lex.c_shipped
+++ b/scripts/kconfig/zconf.lex.c_shipped
@@ -920,7 +920,7 @@ static int input (void );
/* This used to be an fputs(), but since the string might contain NUL's,
* we now use fwrite().
*/
-#define ECHO do { if (fwrite( zconftext, zconfleng, 1, zconfout )) {} } while (0)
+#define ECHO fwrite( zconftext, zconfleng, 1, zconfout )
#endif
/* Gets input and stuffs it into "buf". number of characters read, or YY_NULL,
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-03 13:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-02 5:24 [PATCH 4/4] kconfig: remove unused definition from scanner Martin Walch
2013-10-02 6:42 ` Dirk Gouders
2013-10-02 6:57 ` Yann E. MORIN
2013-10-03 0:30 ` Martin Walch
2013-10-03 6:37 ` Yann E. MORIN
2013-10-03 13:13 ` Dirk Gouders
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox