From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx-relay51-hz1.antispameurope.com (mx-relay51-hz1.antispameurope.com [94.100.132.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD801E1C1A for ; Fri, 12 Dec 2025 14:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=94.100.132.226 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765551368; cv=pass; b=fw7GNbIKLBf0PCZ69OCOi/AKerbBAMbbJ51sVvHHg+zqyLPJgsPJ+4+/6Auw0B+OwORP+Qj8EKIl6VOUKwI1DfGywV6GjmZMoRLa5WLmjmzNR8614DFirs08I7c2PQntsBgNixZb9RN/mwnvmv8I12/cwwl2p05YtSaYXzntd8c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765551368; c=relaxed/simple; bh=WjJGxLw/ZfGT3Gi5LhVmcY0t5C8NSvmtwq1mI+Y4LpM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cMmj5DcQRk6Fa5+QY/dnBxHD3tAdOSjbCTOSqadpiHLMXdWc4dQFVdqWJWy+c3I7rGxbaFRKP5AFIoWzFNQzmJ8kuLnfz+4jFPkFCjWJrL2+2FHilZPmIUiGDAVT1Tpwr+zkQaCpj9pSR9W8HswcFW76QxKVWlXUABLPD5gr+Wk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=LGy2z+oe; arc=pass smtp.client-ip=94.100.132.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="LGy2z+oe" ARC-Authentication-Results: i=1; mx-gate51-hz1.hornetsecurity.com 1; spf=pass reason=mailfrom (ip=94.100.132.6, headerfrom=ew.tq-group.com) smtp.mailfrom=ew.tq-group.com smtp.helo=hmail-p-smtp01-out03-hz1.hornetsecurity.com; dmarc=pass header.from=ew.tq-group.com orig.disposition=pass ARC-Message-Signature: a=rsa-sha256; bh=JRMYAK4i987rLmuuy1ochfKjKJkLu8EMUVwa2tZPjqk=; c=relaxed/relaxed; d=hornetsecurity.com; h=from:to:date:subject:mime-version:; i=1; s=hse1; t=1765551293; b=g4Fo6po3HwfhSG8VrU4bVzH0pPVA5zOZ4TWQFgvjzXUViQRMnxoW+pFyzsfa8t9QfGV0vh0M rhiofwERPm89rqg6p6GLBDjCym/pOxBnqHCy3LuWY4EHQdFme1L2rryc/2PZaovQjbPx0QKETMF Qo8bx99tAQugrYiVK0tSDhNgm1cB/qJ5P2tijLqXRoXKMEzYhQLtHN9uD7FrjuteqxiplwSTqpO K7FpwE1j9ZUaROH3R+BjzJVMOwOu65own+vVQhj5OCOad+qjeTyydsInPrFa2qApelMxRAXpe35 xZVhHTaj3n3v/QrRi/70t/6716+JEA/3Xd/+YwCPuMcyg== ARC-Seal: a=rsa-sha256; cv=none; d=hornetsecurity.com; i=1; s=hse1; t=1765551293; b=lTXdQyM/GyvNljFLxi97i5rOXVLKjKNb7jXdVSNcHnyilgNE03pUn3793dWPJ6Brkgy2J3jT qyjEOLe9Ms+qfi/2BTzK7VrFJIyaOKnApWkW6neVwHRQWDeUxd/0I+M7MHMJ9mNZS7T61ycRxW/ 5YxKuHpx+oK3r5uwwvd9tnisisEqluQBG48MiiBxbd0hNWtw44E3Vv4Dys6XkfCxrYHXXhbUB12 Mt9m4nnNP99VuJzncy5PtewpqJ8X0qVZ8zWr7+Tt6pBM4KP3rceQurWl/r102oqm3zGxAuODwWJ djwrLlQ3eIebjiOF50pBvbyMrR6v/7vugk6Kbo7CIsz1w== Received: from he-nlb01-hz1.hornetsecurity.com ([94.100.132.6]) by mx-relay51-hz1.antispameurope.com; Fri, 12 Dec 2025 15:54:53 +0100 Received: from steina-w.localnet (host-82-135-125-110.customer.m-online.net [82.135.125.110]) (Authenticated sender: alexander.stein@ew.tq-group.com) by hmail-p-smtp01-out03-hz1.hornetsecurity.com (Postfix) with ESMTPSA id 6F440CC0A1D; Fri, 12 Dec 2025 15:54:43 +0100 (CET) From: Alexander Stein To: Ioana Ciornei Cc: Ulf Hansson , Geert Uytterhoeven , Johan Hovold , "Rafael J. Wysocki" , "Rob Herring (Arm)" , Greg Kroah-Hartman , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] irqchip/ls-extirq: convert to a platform driver Date: Fri, 12 Dec 2025 15:54:42 +0100 Message-ID: <6251595.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH In-Reply-To: References: <20251205155735.2366732-1-ioana.ciornei@nxp.com> <2841754.mvXUDI8C0e@steina-w> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5093752.31r3eYUQgx"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-cloud-security-sender:alexander.stein@ew.tq-group.com X-cloud-security-recipient:linux-kernel@vger.kernel.org X-cloud-security-crypt: load encryption module X-cloud-security-Mailarchiv: E-Mail archived for: alexander.stein@ew.tq-group.com X-cloud-security-Mailarchivtype:outbound X-cloud-security-Virusscan:CLEAN X-cloud-security-disclaimer: This E-Mail was scanned by E-Mailservice on mx-relay51-hz1.antispameurope.com with 4dSXYH6XBPz33N6R X-cloud-security-connect: he-nlb01-hz1.hornetsecurity.com[94.100.132.6], TLS=1, IP=94.100.132.6 X-cloud-security-Digest:0bbebf33a8d1f02598eedac45363bb9b X-cloud-security:scantime:2.011 DKIM-Signature: a=rsa-sha256; bh=JRMYAK4i987rLmuuy1ochfKjKJkLu8EMUVwa2tZPjqk=; c=relaxed/relaxed; d=ew.tq-group.com; h=content-type:mime-version:subject:from:to:message-id:date; s=hse1; t=1765551293; v=1; b=LGy2z+oeIrOh+ch6uMJvWwPoexOK09mqJ3I2rdBYGduqgJJE/O5uhMdYjAjL98QpuX06tQ06 BcABc23mDGY7gtrNYTx9+Ht4+TSOSMqTuBuqp71BfeGjN1h90Kk7DFGFVY3K61Lo9xW+hif0cAE FWnEKobUPYEQHz7U8y8B9OjJbtH52mWpUW+G+NMULJYD5Dxgq2HuRXdirGQ0OqQYRRv8gxxT0X6 aQvjheg9bnKv0F6EoFTyxu4ts3e3cFnDhuszmCG0r8Gzwib1k+MLzL//mUy5DkAnOTCUwGGRvfy 5IfcodoqJEw2ZHv7yKAwozZOaNEQprjPGaDuq8v2KE+wA== --nextPart5093752.31r3eYUQgx Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1" From: Alexander Stein To: Ioana Ciornei Date: Fri, 12 Dec 2025 15:54:42 +0100 Message-ID: <6251595.lOV4Wx5bFT@steina-w> Organization: TQ-Systems GmbH MIME-Version: 1.0 Hi, Am Freitag, 12. Dezember 2025, 15:17:05 CET schrieb Ioana Ciornei: > On Fri, Dec 12, 2025 at 10:51:12AM +0100, Alexander Stein wrote: > > Hi, > >=20 > > thanks for bringing this to me. > >=20 > > Am Freitag, 12. Dezember 2025, 02:24:19 CET schrieb Thomas Gleixner: > > > On Fri, Dec 05 2025 at 17:57, Ioana Ciornei wrote: > > > > Since there is no need for ls-extirq to be initialized early, conve= rt it > > > > to a proper platform driver. Instead of using IRQCHIP_DECLARE, add = an > > > > of_device_id array with the same compatible strings as before. Also > > > > change the prototype and name of the probe function and adjust it t= o a > > > > platform_device structure. > > > > > > > > With this change we also have the added advantage of avoiding the > > > > irqchip_init() -> of_irq_init() code path which imposes dt checks t= hat > > > > the ls-extirq does not comply with because of its improper use of t= he > > > > interrupt-map property. > > > > > > > > Fixes: 1b1f04d8271e ("of/irq: Ignore interrupt parent for nodes wit= hout interrupts") > > >=20 > > > I'm not seeing how that Fixes tag is related. Your changelog clearly > > > lacks a proper explanation. > > >=20 > > > Aside of that there is this series: > > >=20 > > > https://lore.kernel.org/20251201105144.539450-1-alexander.stein= @ew.tq-group.com > > >=20 > > > which is way more complete and cleans up the thing nicely instead of > > > just converting it to a platform driver with minimal effort. > >=20 > > There is still one open question: How to deal with the scfg/isc nodes? > > Use patch 2/2 of this series to make them additional pm-busses or move = the > > ls-ext-irq nodes outside of it? >=20 > To move the ls-extirq nodes outside of syscon means that we break > compatibility with the old device trees which I don't like. Yep, me too. > I would much more prefer to use the approach in patch 2/2 of making the > scfg/isc nodes pm-busses. To be honest I'm not fond of it, but if this is the way to keep compatiblity, why not? Let's see what maintainers comment on that. Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ --nextPart5093752.31r3eYUQgx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEByESxqszIvkmWRwbaS+g2M0Z/iUFAmk8LLIACgkQaS+g2M0Z /iVzMQgAwHbKyNx373nZJ6R42aYVUyyYcO72V/7KW8JXkmy362nJWK1BJhqiWFn6 5OpsPiWocGJ6GHxkmxTks0ATGmNIDwjoAZpWMYvPtLOZyUsbL6aCsNIi8mG5wlK7 eyMdFp2GIau/cZwahGZGeclYBqxQhIJRXGKe6/d6U7swYHVR21TW4wMRWsuTHG6S XnJgbVZLDlctzB6se0azo1vCBVHDI6Mj6o/k8uHMX9MxFRuIu1yVH5T2ihdl/gQD rGZHmkqLpeN0m7i59GzFHDV8LEB7jnCPjl94o60KNa3hTvioUduuigK2g2QP6rhm j3nwbRAwDzQ/FF9kw4/slx5WMXUpaw== =GQXK -----END PGP SIGNATURE----- --nextPart5093752.31r3eYUQgx--