Re: [PATCH v2 1/2] irqchip/ls-extirq: convert to a platform driver

Ioana Ciornei
2025-12-12T14:13:51Z

On Fri, Dec 12, 2025 at 10:24:19AM +0900, Thomas Gleixner wrote:
> On Fri, Dec 05 2025 at 17:57, Ioana Ciornei wrote:
> > Since there is no need for ls-extirq to be initialized early, convert it
> > to a proper platform driver. Instead of using IRQCHIP_DECLARE, add an
> > of_device_id array with the same compatible strings as before. Also
> > change the prototype and name of the probe function and adjust it to a
> > platform_device structure.
> >
> > With this change we also have the added advantage of avoiding the
> > irqchip_init() -> of_irq_init() code path which imposes dt checks that
> > the ls-extirq does not comply with because of its improper use of the
> > interrupt-map property.
> >
> > Fixes: 1b1f04d8271e ("of/irq: Ignore interrupt parent for nodes without interrupts")
>
> I'm not seeing how that Fixes tag is related. Your changelog clearly
> lacks a proper explanation.
>

The referenced commit added a check against the presence of the
'interrupts' property for an interrupt controller and only if it exist
it will then call of_irq_find_parent() to gets it IRQ parent.
This change basically broke the ls-extirq.

Converting ls-extirq to a platform driver we are basically avoiding the
irqchip_init() -> of_irq_init() path.

> Aside of that there is this series:
>
> https://lore.kernel.org/20251201105144.539450-1-alexander.stein@ew.tq-group.com
>
> which is way more complete and cleans up the thing nicely instead of
> just converting it to a platform driver with minimal effort.
>

Thanks. I wasn't aware of this series. I will have a look.

Ioana