From: Keith Owens <kaos@sgi.com>
To: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: akpm@osdl.org, tony.luck@intel.com, rohit.seth@intel.com,
rusty.lynch@intel.com, prasanna@in.ibm.com, ananth@in.ibm.com,
systemtap@sources.redhat.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/4] Kprobes support for IA64
Date: Tue, 24 May 2005 15:40:40 +1000 [thread overview]
Message-ID: <6261.1116913240@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Mon, 23 May 2005 08:39:07 MST." <20050523154228.049327000@csdlinux-2.jf.intel.com>
On Mon, 23 May 2005 08:39:07 -0700,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> wrote:
>
>This patch adds the kdebug die notification mechanism needed by Kprobes.
> case 0: /* unknown error (used by GCC for __builtin_abort()) */
>+ if (notify_die(DIE_BREAK, "kprobe", regs, break_num, TRAP_BRKPT, SIGTRAP)
>+ == NOTIFY_STOP) {
>+ return;
>+ }
> die_if_kernel("bugcheck!", regs, break_num);
> sig = SIGILL; code = ILL_ILLOPC;
> break;
Nit pick. Any break instruction in a B slot will set break_num 0, so
you cannot tell if the break was inserted by kprobe or by another
debugger. Setting the string to "kprobe" is misleading here, change it
to "break 0".
next prev parent reply other threads:[~2005-05-24 5:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 15:39 [patch 0/4] Kprobes support for IA64 Anil S Keshavamurthy
2005-05-23 15:39 ` [patch 1/4] " Anil S Keshavamurthy
2005-05-24 5:40 ` Keith Owens [this message]
2005-05-23 15:39 ` [patch 2/4] " Anil S Keshavamurthy
2005-05-23 15:39 ` [patch 3/4] " Anil S Keshavamurthy
2005-05-23 15:39 ` [patch 4/4] " Anil S Keshavamurthy
-- strict thread matches above, loose matches on Subject: below --
2005-05-24 16:20 [patch 1/4] " Lynch, Rusty
2005-05-25 14:00 ` Alan D. Brunelle
2005-05-26 0:49 ` Keith Owens
2005-05-26 1:06 ` Keshavamurthy Anil S
2005-05-26 19:40 ` David Mosberger
2005-05-25 16:46 Lynch, Rusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6261.1116913240@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=akpm@osdl.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=rohit.seth@intel.com \
--cc=rusty.lynch@intel.com \
--cc=systemtap@sources.redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox