From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,global-regs-starting-offset' quirk
Date: Fri, 21 Apr 2023 16:12:33 +0000 [thread overview]
Message-ID: <6273cc836dee42809f6ac5c5cdbcec04@realtek.com> (raw)
In-Reply-To: <CAL_JsqJBDuxCAnZmHBnHuMkjTXTLet2d3o5kLRZQ_YuqVB9Pcw@mail.gmail.com>
Hi Rob,
> Again, we're not going to keep adding properties for every DWC3 variation. If
> it is board specific, then yes a property is appropriate. If it is SoC specific, then
> imply it from the compatible.
> Or in this case, you could possibly add another reg entry.
>
> Rob
>
Let me try to understand your concerns.
The device-tree property should work for all dwc3 IPs and can be specified by different boards.
For a SoC specific, it should use a compatible or registry entry to change it.
So you think we can't use a property to specify this offset.
Is my understanding correct?
If it is right, using property to solve this problem was my mistake.
I will think a new method to resolve it.
prev parent reply other threads:[~2023-04-21 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 6:18 [PATCH v3 1/2] usb: dwc3: core: add support for remapping global register start address Stanley Chang
2023-04-21 6:18 ` [PATCH v3 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,global-regs-starting-offset' quirk Stanley Chang
2023-04-21 13:04 ` Rob Herring
2023-04-21 16:12 ` Stanley Chang[昌育德] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6273cc836dee42809f6ac5c5cdbcec04@realtek.com \
--to=stanley_chang@realtek.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox