From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A05C433F4 for ; Fri, 21 Sep 2018 10:39:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 869532147D for ; Fri, 21 Sep 2018 10:39:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="e80j9Tzx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 869532147D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389728AbeIUQ1R (ORCPT ); Fri, 21 Sep 2018 12:27:17 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:43930 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbeIUQ1R (ORCPT ); Fri, 21 Sep 2018 12:27:17 -0400 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DB2F1275; Fri, 21 Sep 2018 12:38:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1537526338; bh=sm/il1Qy4G1QtCnXyQ9k7TiC+APEkShvRhpDjwwP1sw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e80j9Tzx0MLs43hrg1/L1IZTBeX73HCC18B5kyrgMI5Y6d6PLeTsPdLSB/a7wEjTv UD10UjdZWqddVBMqz3EvSm5odz7TWylSfjwH69i4wx3q3MCu0obOpjMyBGa+HFjFPe KAZTx9EG8XxbE74doKG65mzb6HwMoriAfyWqyuzk= From: Laurent Pinchart To: Ricardo Ribalda Delgado Cc: Sakari Ailus , Hans Verkuil , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] [media] imx214: device tree binding Date: Fri, 21 Sep 2018 13:39:11 +0300 Message-ID: <6279061.hCdAfSGG5i@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180921100920.8656-1-ricardo.ribalda@gmail.com> References: <20180921100920.8656-1-ricardo.ribalda@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, Thank you for the patch. On Friday, 21 September 2018 13:09:19 EEST Ricardo Ribalda Delgado wrote: > Document bindings for imx214 v4l2 driver. Those are bindings for the IMX214 camera sensor, not for its V4L2 driver. > Cc: devicetree@vger.kernel.org > Signed-off-by: Ricardo Ribalda Delgado > --- > .../devicetree/bindings/media/i2c/imx214.txt | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx214.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx214.txt > b/Documentation/devicetree/bindings/media/i2c/imx214.txt new file mode > 100644 > index 000000000000..4ff76d96332e > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imx214.txt > @@ -0,0 +1,51 @@ > +* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor > + > +The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor > with +an active array size of 4224H x 3176V. It is programmable through I2C > +interface. s/I2C interface/an I2C interface/ > The I2C address can be configured to to 0x1a or 0x10, depending > on +how is wired. Maybe "depending on how the hardware is wired" ? > +Image data is sent through MIPI CSI-2, which is configured as 4 lanes > +at 1440 Mbps. Can the sensor use less lanes than 4, or is it fixed ? > +Required Properties: > +- compatible: value should be "sony,imx214" for imx214 sensor > +- reg: I2C bus address of the device > +- enable-gpios: Sensor enable GPIO Maybe "GPIO descriptor for the enable pin" ? > +- vdddo-supply: Chip digital IO regulator (1.8V). > +- vdda-supply: Chip analog regulator (2.7V). > +- vddd-supply: Chip digital core regulator (1.12V). > +- clocks = Reference to the xclk clock. > +- clock-names = Should be "xclk". If there's a single clock, is the name mandatory ? > +- clock-frequency = Frequency of the xclk clock. Should be <24000000>; The frequency of the clock can be queried at runtime. If you want to hardcode a specific frequency in DT, you should use the assigned-clock-rates property. > +Optional Properties: > +- flash-leds: See ../video-interfaces.txt > +- lens-focus: See ../video-interfaces.txt > + > +The imx274 device node should contain one 'port' child node with > +an 'endpoint' subnode. For further reading on port node refer to > +Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +Example: > + > + camera_rear@1a { > + status = "okay"; Isn't that the default ? > + compatible = "sony,imx214"; > + reg = <0x1a>; > + vdddo-supply = <&pm8994_lvs1>; > + vddd-supply = <&camera_vddd_1v12>; > + vdda-supply = <&pm8994_l17>; > + lens-focus = <&ad5820>; > + enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>; > + clocks = <&mmcc CAMSS_MCLK0_CLK>; > + clock-names = "xclk"; > + clock-frequency = <24000000>; > + port { > + imx214_ep: endpoint { Incorrect indentation ? > + clock-lanes = <1>; > + data-lanes = <0 2 3 4>; Those properties are not documented. The data-lanes value is peculiar, does the sensor support lanes remapping ? > + remote-endpoint = <&csiphy0_ep>; > + }; > + }; > + }; -- Regards, Laurent Pinchart