From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 422583E92BB for ; Fri, 17 Jul 2026 09:47:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784281663; cv=none; b=ZvWUoS0XtsKUHo+eAvGIkB9y6sPgQ40ooitc54kQSWjKBjIKTtJ4svBWcwfPG3mNOVU8WgpZ8WsyAk3+SewVE0/XwRWRWwZ3sEb4rxdVdL6ikYZOjsD75IuYY79zCkovpqjY5BWN2fWeJTjolCjXHlbOetlA8eWVMZNDuWkaweo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784281663; c=relaxed/simple; bh=SA1xMJwP+nvYyGy44ETv4g2iY2c92GT627gCU7j/mvk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tWl59DJ1LRv3CyCqNelBkjHls8x9WXWhrzu1Ctr077NZXQCx9pvHUvorGcaLke3T42X5/xqp8OrEwuPuE1Y3oFsJUFeh6jwAW5baOUNCEq28NUJ2j60yupoYk2NqLJcRORq7NH/CfGZkPEhHrNk5t5xsOCjdaWVB0Q0emFhyGoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UU7k55Gb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=biEu05Gn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UU7k55Gb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="biEu05Gn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784281658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9UfOzvi3ApW9raJzhRo6rILl0ALfG4yRcSmV5u5K+uI=; b=UU7k55GbCcSkwBq5uFBCnKdeGSmiqvR6lew60/LXquZdfA59qwPQRi8PGY2l2etTvNMjbY y2akSSbghmrEn8yn177ChV45PfTFAGpjHrwVktKugfeqKqt+JZn/EnZdRT4XgcxdiNvAJ5 Aevjkb/xrUqR9au4dQ1C9s5rfy2NqK8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-PtiBrpfCO62GBltzoCL-6A-1; Fri, 17 Jul 2026 05:47:36 -0400 X-MC-Unique: PtiBrpfCO62GBltzoCL-6A-1 X-Mimecast-MFC-AGG-ID: PtiBrpfCO62GBltzoCL-6A_1784281656 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-493b54823bdso7654675e9.0 for ; Fri, 17 Jul 2026 02:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784281656; x=1784886456; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9UfOzvi3ApW9raJzhRo6rILl0ALfG4yRcSmV5u5K+uI=; b=biEu05Gn5HD8F1jh70HJev6VmEZn/2sbOt2gdfet6bGjvypoifFzwOqUWOrraULmg8 09cPwrUyVPKE4G+bBVsqhYcbvtNYd2ODJE3NLCG6Bx3vVG4Hsn18SG+mzFV+bRiURXg1 ZIkL93uPBQeKxoVPV8z/s0Mt2mNRHFLI2mn4UvRqJVxNs+uJVJOD7/G8Po6F9suZST2B iGFtNU5lug1jNwLVEenUpQ8jyan55L264JiOQCQ1Xp8ox+yxL3ia9BM9CGKLXWpD6Vm3 n6zSfwGxelzZ5hG90VkDR8Mcc8Qy1K1CuOa23lmE0oJf60kV21tCAD2RB1pnl4FPsNBc jmBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784281656; x=1784886456; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9UfOzvi3ApW9raJzhRo6rILl0ALfG4yRcSmV5u5K+uI=; b=EI4vD1FZlvoY5se9ALsb7jy9X4D4JKNMCr0CIqJyi3X68p51h86p4yh2RyDMjZI9ZZ Esn0jrKg1xJrxedwJ1v41E3lIzsPX38yEU53JuDYnDlWnJ2Tt9iOZj0guYV54Un543Gz Gq5lyWVjxOFBgyy3rzptNMkwrZ2zRSy69S3COYS9qYDx6FhiuJPEASEfC4x98dEIc1U9 t87wVxmWygO5KUvLrccSvvUs4zsW2D4G9Q4ir9NVlTKsfYi5vb+5VdG8x9Uywnh3zT4r n0exHKdHCcdH3Hj9VL6bPzvkHzNIELwZwKWx9AZMT0iecI3GDoRMc3NifSHWaCozxIty mTrw== X-Forwarded-Encrypted: i=1; AHgh+RrDPxJynPXXpFAWiZEoBEgzlomGCmRhy2lYAolDFe66jXEuK5T8tM4NZtrsS/t6nmFYwGzWccV3i10mBZ4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyb9nqqgRUgYwQb9iOUC4LhDqgDOy5BYV0ow8FMCXB7GaIcXzrC khlIthZNtxx2rWuEf7Pe2J8CK0SIN7OOKUkW1YujzYUhBcNzOFsKSQxHypYVg3Z2KwBLalWvLdE xhdjoUAsshvIGsMErxkDJ8ReIp4gx7QqbxoUiw8xdTI/+SOiw2Iqg0/pSzgHA8ITD2w== X-Gm-Gg: AfdE7cldsEs5H48/PPzykhwNoGfrxNYgOf7SZh2wcLoFai8I95ZPhX+8HL1+lClBpx5 s8ceXAX86sp8enSrp0yipaxYd/GrKc8l3tgymXHl5Ge3JKN+vPgssUlcX6ujyUwsstJxbL5ZJ4Y gUiYoLO5W1e083td9aKr2n24jX6FD0sz8JjIIZ6MJC9eYJqwbSNsAPGX2bMznHs3QaVdCcc6NsS SsnT26vifsKb7VqgyyIlT9A7Ye8wKTEKapb7YEK+lJKhIfFMqVja6gGXpdcn0aOHh5Lz3JPjUin PqiEHqDs0Vw/tJycM1xm9AaSldXpJ8sqPdwIFmZHiqRVTSirM8AwtuT3nMco8Bym1wkoH8g/3kv MdnkcgP+dcoc69HrLhpt3l1HV73YkvDqpstI0n9BnC7hLb+N+N+9unybjgX47KNS3Oo0fA3omQb NUqg== X-Received: by 2002:a05:600c:35d1:b0:495:3a52:71b1 with SMTP id 5b1f17b1804b1-4954aa1a34fmr16278955e9.5.1784281655570; Fri, 17 Jul 2026 02:47:35 -0700 (PDT) X-Received: by 2002:a05:600c:35d1:b0:495:3a52:71b1 with SMTP id 5b1f17b1804b1-4954aa1a34fmr16278655e9.5.1784281655105; Fri, 17 Jul 2026 02:47:35 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2edbe4sm35888375e9.12.2026.07.17.02.47.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 02:47:34 -0700 (PDT) Message-ID: <62b9c471-e6a0-472b-a549-81128cb9a8ac@redhat.com> Date: Fri, 17 Jul 2026 11:47:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net/mlx5: free mlx5_st_idx_data on final dealloc To: Leon Romanovsky Cc: Zhiping Zhang , Jason Gunthorpe , Saeed Mahameed Michael , Tariq Toukan , Mark Bloch , Michael Guralnik , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260702222507.1234467-1-zhipingz@meta.com> <9e4e455b-c10b-447e-9fe6-80672f26fd8a@redhat.com> <20260713080816.GA327832@unreal> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260713080816.GA327832@unreal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/13/26 10:08 AM, Leon Romanovsky wrote: > On Fri, Jul 10, 2026 at 01:25:45PM +0200, Paolo Abeni wrote: >> On 7/3/26 12:24 AM, Zhiping Zhang wrote: >>> Workloads that repeatedly allocate and release mkeys carrying TPH >>> steering-tag hints (e.g. churning RDMA MRs) leak one >>> struct mlx5_st_idx_data per cycle; kmemleak flags it as unreferenced >>> and the kmalloc slab grows over time. >>> >>> When the last reference to an ST table entry is dropped, >>> mlx5_st_dealloc_index() removed the entry from idx_xa but the backing >>> mlx5_st_idx_data allocation was never freed. >>> >>> Free idx_data after the xa_erase() so the lifetime of the bookkeeping >>> struct matches the lifetime of the ST entry it tracks. >>> >>> Cc: stable@vger.kernel.org >>> Fixes: 888a7776f4fb ("net/mlx5: Add support for device steering tag") >>> Reviewed-by: Michael Gur >>> Signed-off-by: Zhiping Zhang >> @Leon, @Saeed, @Tariq: just in case this fell under the radar, it's >> waiting for your ack. > > Tariq and I completed this on Jul 5 and Jul 6. > > https://lore.kernel.org/linux-rdma/20260705141920.GI15188@unreal/ > https://lore.kernel.org/linux-rdma/0bb37f75-c94a-4a10-b115-186b71daf14f@nvidia.com/ Thank you for pointing out and for the review. PW lost track of it, likely because there are multiple copies of the same patch/revision and only one of them landed on the netdev ML. Applying right now. /P