Re: [PATCHv4 01/30] x86/mm: Fix warning on build with X86_MEM_ENCRYPT=y

Borislav Petkov
2022-03-01T08:48:54Z

On Mon, Feb 28, 2022 at 09:11:59AM -0800, Josh Poimboeuf wrote:
> People rely on the "Fixes:" tag for actual bug fixes. Using it here --
> along with the rest of the "this is fixing a bug" tone of the title and
> description -- is guaranteed to confuse stable maintainers and distros
> doing backports.

Yes, they very much do. There's even automatic tools which look at Fixes
and give people work. So yeah, pls don't take this lightly.

> I would call it misinformation. How is that useful?
>
> It's ok to reference a related commit in the patch description itself.
> Just don't abuse the "Fixes" tag.
>
> But IMO, for the least amount of confusion, it makes more sense to
> squash this with the patch which actually requires it.

Full ack. Please squash it into the patch which causes the issue. And
frankly, I don't understand why you guys are making such a fuss about it
and why this needs to be a separate patch, at all?!

Thx.

--
Regards/Gruss,
Boris.