Re: [PATCHv4 01/30] x86/mm: Fix warning on build with X86_MEM_ENCRYPT=y

Dave Hansen
2022-02-24T16:09:36Z

On 2/24/22 07:56, Kirill A. Shutemov wrote:
> So far, AMD_MEM_ENCRYPT is the only user of X86_MEM_ENCRYPT. TDX will be
> the second. It will make mem_encrypt.c build without AMD_MEM_ENCRYPT,
> which triggers a warning:
>
> arch/x86/mm/mem_encrypt.c:69:13: warning: no previous prototype for
> function 'mem_encrypt_init' [-Wmissing-prototypes]
>
> Fix it by moving mem_encrypt_init() declaration outside of #ifdef
> CONFIG_AMD_MEM_ENCRYPT.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Fixes: 20f07a044a76 ("x86/sev: Move common memory encryption code to mem_encrypt.c")
> Acked-by: David Rientjes <rientjes@google.com>

Hey Kirill,

The last time you posted this, I ack'd it:

Acked-by: Dave Hansen <dave.hansen@linux.intel.com>

but that didn't make it into this version. It saves me the trouble of
looking through this patch again when I was fine with it last week.

The ack still stands if you're interested in incorporating it. ;)