public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Marangi <ansuelsmth@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 3/5] dt-bindings: arm: msm: Rework kpss-gcc driver Documentation to yaml
Date: Fri, 1 Jul 2022 19:32:13 +0200	[thread overview]
Message-ID: <62bf3292.1c69fb81.f66df.44ed@mx.google.com> (raw)
In-Reply-To: <20220701173238.GA1175908-robh@kernel.org>

On Fri, Jul 01, 2022 at 11:32:38AM -0600, Rob Herring wrote:
> On Wed, Jun 29, 2022 at 02:14:39PM +0200, Christian Marangi wrote:
> > Rework kpss-gcc driver Documentation to yaml Documentation.
> 
> It's not 'driver Documentation'. It's a DT binding for h/w.
> 
> Lot's of things are YAML. I prefer 'DT schema'
> 
> The subjects are bit long and get cut off as well. For the subject, 
> something like:
> 
> dt-bindings: arm: msm: Convert kpss-gcc to DT schema
> 
> And similar for the other patch.
>

It was pointed out that since this have additional change than simple
conversion, using "Convert" can be confusing.
Is Rework or Refactor a better naming for this single patch?

> > The current kpss-gcc Documentation have major problems and can't be
> > converted directly. Introduce various changes to the original
> > Documentation.
> > 
> > Add #clock-cells additional binding as this clock outputs a static clk
> > named acpu_l2_aux with supported compatible.
> > Only some compatible require and outputs a clock, for the others, set
> > only the reg as a required binding to correctly export the kpss-gcc
> > registers. As the reg is shared also add the required syscon compatible.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> >  .../bindings/arm/msm/qcom,kpss-gcc.txt        | 44 ---------
> >  .../bindings/arm/msm/qcom,kpss-gcc.yaml       | 90 +++++++++++++++++++
> >  2 files changed, 90 insertions(+), 44 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
> >  create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml

-- 
	Ansuel

  reply	other threads:[~2022-07-01 17:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 12:14 [PATCH v4 0/5] Krait Documentation conversion Christian Marangi
2022-06-29 12:14 ` [PATCH v4 1/5] dt-bindings: clock: Convert qcom,krait-cc to yaml Christian Marangi
2022-06-29 12:14 ` [PATCH v4 2/5] dt-bindings: arm: msm: Convert kpss-acc driver Documentation " Christian Marangi
2022-06-29 22:36   ` Rob Herring
2022-06-29 22:38     ` Christian Marangi
2022-07-01 17:26   ` Rob Herring
2022-06-29 12:14 ` [PATCH v4 3/5] dt-bindings: arm: msm: Rework kpss-gcc " Christian Marangi
2022-06-29 22:36   ` Rob Herring
2022-06-30  6:43   ` Dmitry Baryshkov
2022-06-30 11:20     ` Christian Marangi
2022-07-01 17:32   ` Rob Herring
2022-07-01 17:32     ` Christian Marangi [this message]
2022-06-29 12:14 ` [PATCH v4 4/5] ARM: dts: qcom: fix various wrong definition for kpss-gcc node Christian Marangi
2022-06-29 12:14 ` [PATCH v4 5/5] ARM: dts: qcom: fix various wrong definition for kpss-acc Christian Marangi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62bf3292.1c69fb81.f66df.44ed@mx.google.com \
    --to=ansuelsmth@gmail.com \
    --cc=agross@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox