From: Tom Lendacky <thomas.lendacky@amd.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Laura Abbott <labbott@redhat.com>
Cc: Borislav Petkov <bp@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Brijesh Singh <brijesh.singh@amd.com>, X86 ML <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Boot regression with bacf6b499e11 ("x86/mm: Use a struct to reduce parameters for SME PGD mapping") on top of -rc8
Date: Fri, 19 Jan 2018 22:13:56 -0600 [thread overview]
Message-ID: <62c64d88-8a97-8c97-d8ee-29b577c72c99@amd.com> (raw)
In-Reply-To: <CA+55aFy3Agx5ngYERyJZhLkgA1oP1e48VY4hPw0H5Yopw_GdGA@mail.gmail.com>
On 1/19/2018 8:38 PM, Linus Torvalds wrote:
> On Fri, Jan 19, 2018 at 5:23 PM, Laura Abbott <labbott@redhat.com> wrote:
>>
>> Fedora got multiple reports of an early bootup crash post -rc8.
>> Bisection showed bacf6b499e11 ("x86/mm: Use a struct to reduce
>> parameters for SME PGD mapping") . It doesn't revert cleanly
>> but if I revert the few other changes in arch/x86/mm/mem_encrypt.c
>> as well it boots up fine.
>
> Odd. I've tried to read through that patch three times to find
> anything it actually changes, and I can't find anything.
>
> It looks like that patch should have absolutely no actual behavioral impact.
>
> But clearly I'm missing something. Can anybody see what the mistake in
> the conversion is?
I'll take a closer look at this, but it really shouldn't have any effect,
especially on a non-AMD box (which I'm assuming this is?) and with memory
encryption off by default.
Thanks,
Tom
>
> Linus
>
next prev parent reply other threads:[~2018-01-20 4:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 1:23 Boot regression with bacf6b499e11 ("x86/mm: Use a struct to reduce parameters for SME PGD mapping") on top of -rc8 Laura Abbott
2018-01-20 2:23 ` Gabriel C
2018-01-20 4:02 ` Laura Abbott
2018-01-20 5:25 ` Gabriel C
2018-01-20 6:15 ` Tom Lendacky
2018-01-20 6:57 ` Laura Abbott
2018-01-20 7:03 ` Laura Abbott
2018-01-20 12:08 ` Gabriel C
2018-01-20 12:33 ` Ingo Molnar
2018-01-20 13:13 ` Ingo Molnar
[not found] ` <d2b236d9-ccfc-0cd0-f097-9daba70b86ff@redhat.com>
2018-01-20 17:34 ` Tom Lendacky
2018-01-21 1:14 ` [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel Laura Abbott
2018-01-21 1:23 ` Linus Torvalds
2018-01-21 1:49 ` Gabriel C
2018-01-21 4:16 ` Linus Torvalds
2018-01-21 9:37 ` Greg Kroah-Hartman
2018-01-21 9:50 ` Ingo Molnar
2018-01-21 10:36 ` Greg Kroah-Hartman
2018-01-21 8:46 ` Ingo Molnar
2018-01-20 12:01 ` Boot regression with bacf6b499e11 ("x86/mm: Use a struct to reduce parameters for SME PGD mapping") on top of -rc8 Gabriel C
2018-01-20 2:38 ` Linus Torvalds
2018-01-20 4:13 ` Tom Lendacky [this message]
2018-01-20 12:12 ` Ingo Molnar
2018-01-20 15:35 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62c64d88-8a97-8c97-d8ee-29b577c72c99@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox