Re: [net-next PATCH v2 06/15] net: dsa: qca8k: move port set status/eee/ethtool stats function to common code

Vladimir Oltean
2022-07-19T14:05:29Z

On Tue, Jul 19, 2022 at 03:16:24PM +0200, Christian Marangi wrote:
> On Tue, Jul 19, 2022 at 04:14:51PM +0300, Vladimir Oltean wrote:
> > On Tue, Jul 19, 2022 at 02:57:17AM +0200, Christian Marangi wrote:
> > > The same logic to disable/enable port, set eee and get ethtool stats is
> > > used by drivers based on qca8k family switch.
> > > Move it to common code to make it accessible also by other drivers.
> > >
> > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > > ---
> >
> > Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
>
> (considering the ethtool function will change, is it OK to keep the
> review tag on the next revision?)

As long as the removed code is identical to the added one, yes.
If there are problems with the changes on the ethtool_stats function,
I'll leave my comments there.