From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F3D644C4EE for ; Tue, 25 Aug 2026 13:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787663554; cv=none; b=T8Fy2DwVwxs4m/T2x3GhVOUTp0DCzj7fDuvGJbO3UNfBxTb64tpppLMajH19uxKQ8J7/lyhF1md78gCP4S33O91/7LgBbXEpBzAUDAJ/3xqThG9rbe4IU2K2Q7szLC/yRGtCQBUH6X0OIPT+6cE0muvECo91E53PBeOZ+2/+60M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787663554; c=relaxed/simple; bh=5vSoQjlM+zxdMgIz8Dol2JEbHZmwoaaMs/VLIvAbY28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hy39DwicgsEcCJBCH3u9w9PDDel7eukO/FIAyhhKNbk3octil6IK+7tXhP+Yvs8ROY9mEfRs1IO+zXDnMql9+BhDenU45X1rIaGJvBfMUI2Evz/T5WYEvPSSdb++S1gxPCxDeVPPOax04aNFG3RK5PCuZ0KDLDwlziFVgBGoopw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ih3upoVv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QPGiDw5W; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ih3upoVv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QPGiDw5W" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67PAvhWe1638847 for ; Tue, 25 Aug 2026 13:12:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wEk50R8qPbR/0VyfuOs/yn87UGRyRMpG1iyvWD2oRYY=; b=ih3upoVvWO7rwhOt pW0zfvOZnbOJj1RV6iSkTKQ66LmQyRmQH+OMAlTk0/eFOGjcZUz2nmXOnZOojX1e gHGKUtr9u0PAngik3UhDSyFasPB+lhxzq5et+Cq4sqc2VckLqLmEaBnelrK/igW4 MUKZq4PXWjIg+5e6ZXcCauLt0JlmFYvjX2e5lfTYGfu57/OCoR3RDIubf7OVxE9f ug+Xe0EFxF9jPU2dlRn2lX1CW6OHVwAVynVNtg9/Jphp0IbOzvLuUixsPX5fX7jO eWNy1Si71YX7hsJuRqgVfDcJpjEy9BnBOfRmXDk3iwBhKR9iaFzYZrOQXa7sLx9L vJnj/w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8t1s4231-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 13:12:24 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-936708f129aso405430585a.0 for ; Tue, 25 Aug 2026 06:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787663540; x=1788268340; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wEk50R8qPbR/0VyfuOs/yn87UGRyRMpG1iyvWD2oRYY=; b=QPGiDw5WID17iXBiB7qrWFPAsqvSLpnCL6PYEQSygC70Q+Dbn9dZF1eABD22thKibZ ClWRJi7OTPgSz6h8l0Y2H98rPiYu1M/GvVbPo96B6IouLo6QfgLzuDy/t3ETBeOm7etz aIPO8mrDavJSaOihe5KXsESvTNNWeS/WU3TeELsNmI/1VJbcGEDLFtSajw10WaLqCdp+ bRXKoG2kVLSmVm6iJXPi9Okkh34rsZflhhxjTwDx057un9oZtxirSNrQ+BHC6W4Nj0d0 apyEvxzZSGMlmB+LZE6z8ELGs1FNbUfQ5H9Ohkp1DpPs/h1LbCugC6inUmUzan7qt/M5 jYww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787663540; x=1788268340; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wEk50R8qPbR/0VyfuOs/yn87UGRyRMpG1iyvWD2oRYY=; b=OtCYbpvI5hXCFwxrrylJzXk9wkzi7Nqf3xoWw3sHYywaHomaTAuT1r1/koB8oSf8ku 6yTPy3qUwp0qz0ggTvS5Ycowxk+M3MMTYJ7PmilzfSf8t2HfUYjGFJlwSKoObaV8oeeh qW6Pi7dGHaH+iGAtP77LTHIdCwNVxZ1v21BL6fTkLIuz4mKWQnXbvNhZvK4HeQ7Aw/Id RBFrxPKNeH9Rxhfp7TArap+wGi3jU4qjW8qtaA5FnRXVj5SMRlc/jKGCMW4DBts/iEnG E59aUKck7ywmAVIgxxuMV86UqkxqvyTEbw/Eejryt9WI/gDr5+JgDw00pvPkw8ken7BD NGNg== X-Forwarded-Encrypted: i=1; AHgh+RrBSvCTflXpS3wlhk9jBTGQVzNm0lNZAUkxG0a385gAFQPDXS3ktnk+d1etNXxenpK69+lP++iMm5csy2I=@vger.kernel.org X-Gm-Message-State: AFuF++kFRlLzJHY1iCwsEGbghQnumyuQ72NGBWFkAcyxR4v7THk4NFFz WX+PQEZ1wMNk1eQN1Lwalj9P0veeX4kfDQg7Fipd29boCdwraYGy1xKqJTcp8Z8KaQ8GzCDzzx/ 7GEEemPfqTXUzCILRpHSYvbnJ2CEYQ7VV0+7swRYpz+jiGPm2kCkCzfkV1Cx/6CuIWKg= X-Gm-Gg: AR+sD13v8movzc8lFfQ4Yy3CmoeyrbEBahIhrZAJQ779WkFyyYIG9RHRxVY7lN3mCgH AyiXoFZFf/f6I7KjS34kEMMxW57cDLnJNFnTBCkUgdha2dBOF6K9bD89NgCvXKrRIPfAUmAXj4K BSUbA2Iqzi8fURkXTSpKG7uniA9p9RHTVhultFvS2hyqrr4WGX1zVQnZEwA5jn4XmUtQ11JH2K1 +pXr/409XHp+htdsKw0aSedG+RqaVPhN2H1SPeDcRA/aCkSxLBCuw7psha3EM90vBH9xI5/5glO L3f0uS/k5B3cQmppIBKKVAhH8BMbGH8eVXiaPkXjlazwQYH+GqLzJ9e7PDYOaXVzYVLbVK2O81G 8eVvT2wKb5HIKBbacJB74zm0+AjzB7kM4GIQ= X-Received: by 2002:a05:622a:e0c8:10b0:52e:a11:571e with SMTP id d75a77b69052e-52e0a1169f2mr162418941cf.11.1787663540351; Tue, 25 Aug 2026 06:12:20 -0700 (PDT) X-Received: by 2002:a05:622a:e0c8:10b0:52e:a11:571e with SMTP id d75a77b69052e-52e0a1169f2mr162418021cf.11.1787663539783; Tue, 25 Aug 2026 06:12:19 -0700 (PDT) Received: from [10.217.218.158] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482c9b69b7fsm11808333f8f.2.2026.08.25.06.12.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 06:12:15 -0700 (PDT) Message-ID: <62ebdf78-85fd-4209-92fe-acda654a2e6f@oss.qualcomm.com> Date: Tue, 25 Aug 2026 18:42:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spi: qcom-geni: rename setup_fifo_params() to setup_spi_params() and make it void To: Abel Vesa Cc: Viken Dadhaniya , Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260824-spi-qcom-geni-cleanup-setup-fifo-params-v1-1-bdf98ae62953@oss.qualcomm.com> <8e4684d0-d130-4c75-8b28-11fd98fc4a29@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: H1qb6BRM1rHXNAGaZH1Z1aqnDh74-1DL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDExMiBTYWx0ZWRfX7j8AOkA3hVXy r+uVWiApTSqMPpKGrjc/ZyUPq2mqlEXBpp5kiLA0L7PcM88swbooPKgeE4V4u1JjAyNC93z/PJK sJFZdZYl04k9LTGB2cLv8Wc4+MpfyPFyL2uMnrWwVKWY95wVrWQR1KS8GgaOIgKkImGM+XQPHDf L1J1S+S0fB+k6kD+7gJvoGNj5Cw1DbTpn+ERVFy+ZrB2GT6igKoAe/SlAcznbaGFpm1T4Pvnh31 VrzecrQUdwrwvb4L3jautGvR5ZXCSBaI/LU9UPFWO16bIEv9jCETB/kKno+k9zf3wfyOz8UDQ7z ZjftgB9Dx5dbUj4sNZ4QNBqTIvuhg4bLK3U2K5obQk9ADYXqKXrg+KB6B2J7nyUeTIvly1NSeKI cZ82M/83T7galIHvcaU6wcgXfcKsEr2kTkEvtS6ydexcSw0dsgezQI70bR2/hnta5FkzcPc5MeT A41XkN/urAXcFKN+MNQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDExMiBTYWx0ZWRfX1B8M8aqh1uxW eRdxVvAZpuxCi5lXZYoYTL1xyRtKtLMTf+G3rxJq5vKgMH+lfO2LFsG/66NZ1+sCz/U53GVk6qz gQoeCY+khxljEsQylDzsozqiz4ewxl4= X-Authority-Analysis: v=2.4 cv=L7ItheT8 c=1 sm=1 tr=0 ts=6a8d94b8 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=O7rPFSPfsRJ4j1pAWDsA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: H1qb6BRM1rHXNAGaZH1Z1aqnDh74-1DL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_03,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 impostorscore=0 spamscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250112 On 8/25/2026 3:39 PM, Abel Vesa wrote: > On 26-08-25 14:01:10, Mukesh Savaliya wrote: >> >> >> On 8/24/2026 3:43 PM, Viken Dadhaniya wrote: >>> The function always returned 0 and had no error paths, so change its >>> return type to void. Drop the now-dead ret variable and error check >>> in spi_geni_prepare_message(). >>> >>> setup_fifo_params() is called for both GENI_SE_FIFO and GENI_SE_DMA >>> modes, so the "fifo" in the name is misleading. Rename it to >>> setup_spi_params() to better reflect its purpose of configuring SPI >>> mode parameters (CS, CPHA, CPOL, loopback, LSB-first). >>> >>> No functional change. >>> >>> Signed-off-by: Viken Dadhaniya >>> ---Reviewed-by: Mukesh Kumar Savaliya > > FYI, there is a chance these might not be picked up by b4, when > applying. > > Make sure when you reply with tags, they are actually part of the new > message. Thanks Abel for pointing this ! i realized line got mixed.