public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: CGEL <cgel.zte@gmail.com>
To: Joonsoo Kim <js1304@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	mm-commits@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Hildenbrand <david@redhat.com>,
	corbet@lwn.net, bsingharora@gmail.com, yang.yang29@zte.com.cn,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: + filemap-make-the-accounting-of-thrashing-more-consistent.patch added to mm-unstable branch
Date: Fri, 12 Aug 2022 07:24:42 +0000	[thread overview]
Message-ID: <62f6003b.170a0220.e7d9.1bbb@mx.google.com> (raw)
In-Reply-To: <CAAmzW4NAe2RBmw_OwRVOE+PEEwABrLzAQrVtFJBA7gZNm__oiw@mail.gmail.com>

On Fri, Aug 12, 2022 at 03:45:09PM +0900, Joonsoo Kim wrote:
> 2022년 8월 12일 (금) 오후 12:48, CGEL <cgel.zte@gmail.com>님이 작성:
> >
> > We have discussed related question before. See:
> > https://lore.kernel.org/all/Yio17pXawRuuVJFO@cmpxchg.org/
> > The problem is that there is no suitable place to measure pagecache thrashing
> > in fs level likes swap_readpage(). We have to measure it in folio_wait_bit_common().
> >
> > If we measure swap thrashing just in swap_readpage(), we will miss pagecache
> > thrashing. If we measure swap thrashing in swap_readpage(), and measure
> > pagecache thrashing in folio_wait_bit_common(), it will be rerpeated calculation.
> 
> Maybe, repeated calculation issue could be easily solved by
> re-entrance detection on
> delayacct_thrashing_start().
>
If no other suggestion from others, I will commit another patch
to realize this.

And I think this patch will not conflict with the later patch.

Thanks.

> Thanks.

      reply	other threads:[~2022-08-12  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220811215204.64911C433D6@smtp.kernel.org>
2022-08-12  2:20 ` + filemap-make-the-accounting-of-thrashing-more-consistent.patch added to mm-unstable branch Joonsoo Kim
2022-08-12  3:48   ` CGEL
2022-08-12  6:45     ` Joonsoo Kim
2022-08-12  7:24       ` CGEL [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62f6003b.170a0220.e7d9.1bbb@mx.google.com \
    --to=cgel.zte@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox