From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754021AbdAJVjx (ORCPT ); Tue, 10 Jan 2017 16:39:53 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:53814 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620AbdAJVju (ORCPT ); Tue, 10 Jan 2017 16:39:50 -0500 From: Arnd Bergmann To: Darren Hart Cc: Benjamin Tissoires , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: shut up unused-function warning Date: Tue, 10 Jan 2017 22:39:04 +0100 Message-ID: <6301921.5KldR71luq@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20170110204117.GB4371@f23x64.localdomain> References: <20170110152857.3140948-1-arnd@arndb.de> <20170110204117.GB4371@f23x64.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BdBB58tqfiXpMiliUdCPuF8npeZQa+P9j8E3SgkZw61RwXqXkxH dsZSoq70dydvKjUZPSy5N8RJYtTSdxQSXTN5HGnhNjrf6dmMtcR2294aZmmHjRodfQZEhg9 YW3ttS4eT0/vuxSt3+oZB/8pfWW+osW1jYuHjxp4l2bH1LpohvZAsruy41TK3gyZSEEjYnx 0gVJh81PxOHDngXDQGgkQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:tO96t2ASJ6c=:xyX9Iy3W1ZqrGBJukm8FS2 G0Aig1yVo8gEVj5wGRVn2JQNRgFfRaRhelZ+S8PdqmrKfS7ytWkvE7e8p1ibqABD31MOYPFYY 0zLbjyGBcgBT5qBKOm1qDlG/tObe1LsCO/YfGZSvIg966V+00YmTxaP32U+tt4gSSUfTcxQLC mEDJPXNq4ZVNA4EHHCUMhKxZa8EtkxRKNE0m6vUTUdKVFupybvFcI+HBAi5Q310J6bmATd0db okz1MGm67hYarJRoxkKOaEyG19V1H5IprHnIFBX83zO7tbyb56zLgl1Dd7MgiVQi4nInsPgsO ryvTasI82LUjA5/2e7sLZtW/ZXcIW5RL5jS0z4ZUQAaYL8GuOqFoN8liZuz8RAzwMLiQEXyPk KyT/ZyZV88fmrkI3QBvzMayYgxXivvflR3Kx0j3zQH6u9Iw+zVqczI3lMOd2u4OQJNYr8JaBj bxrvRd4SLyAHgB0VWK86O9Gev+m86AQ/qADqG7uGoBdSbiL118OzhEoV1Z5cB2qpC9VY6duw9 JOsYW3TX5kB8JU5Pc47Mk4nOOYk4Jg2THjjkd2jidUyF3aG8/thvDiHsBjgLVgLrNr1ZDUyHN SxqAhHPky3uclS5rS6PetFQt9CkGKZRPBEB0QeYPX43TOr5GGpQxjJ9BsaFrqfur7GQwhf1Ox JIoH5VRSUXKlUvmxEph+4+Z4xb3p1FzXCVlUG7Ehsa1wYAaaIqGl9j+WCJ7ap1fWqW/bo8a8z OtUc1qaehXzgjjWA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 10, 2017 12:41:17 PM CET Darren Hart wrote: > > Thanks Arnd, > > This appears to be the preferred approach from coding-style.rst 20) Conditional > Compilation - we have some cleanup to do in this area I guess. > > Queued to next, thanks. Thanks! No need to do mass-conversions to __maybe_unused though, Kirtika Ruchandani has started working on a way for the suspend/resume functions to automatically get silently discarded when they are unused, without having an #ifdef or __maybe_unused annotation. For new code, using __maybe_unused helps avoid this bug though, and the conversion to the future macros would be easy enough. Arnd