From: David Howells <dhowells@redhat.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: dhowells@redhat.com, ard.biesheuvel@linaro.org,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"H. Peter Anvin" <hpa@zytor.com>, Peter Jones <pjones@redhat.com>
Subject: Re: [PATCH 5/8] efi: Get the secure boot status [ver #6]
Date: Mon, 23 Jan 2017 22:11:43 +0000 [thread overview]
Message-ID: <6306.1485209503@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170123212642.GA2766@codeblueprint.co.uk>
Matt Fleming <matt@codeblueprint.co.uk> wrote:
> > (4) extract_kernel() calls sanitize_boot_params() which would otherwise clear
> > the secure-boot flag.
>
> The ->sentinel flag should be clear (because you zero'd boot_params on
> alloc), so the code inside of sanitize_boot_params() should never
> trigger for the secure boot case.
But it *does* trigger, otherwise I wouldn't've noticed this.
David
next prev parent reply other threads:[~2017-01-23 22:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 12:30 [PATCH 0/8] efi: Pass secure boot mode to kernel [ver #6] David Howells
2016-12-08 12:30 ` [PATCH 1/8] efi: use typed function pointers for runtime services table " David Howells
2016-12-08 12:30 ` [PATCH 2/8] x86/efi: Allow invocation of arbitrary runtime services " David Howells
2016-12-08 12:30 ` [PATCH 3/8] arm/efi: " David Howells
2016-12-08 12:30 ` [PATCH 4/8] efi: Add SHIM and image security database GUID definitions " David Howells
2016-12-08 12:30 ` [PATCH 5/8] efi: Get the secure boot status " David Howells
2017-01-11 14:33 ` Matt Fleming
2017-01-11 15:27 ` David Howells
2017-01-16 14:49 ` Matt Fleming
2017-01-16 15:39 ` David Howells
2017-01-23 10:52 ` David Howells
2017-01-23 21:26 ` Matt Fleming
2017-01-23 22:11 ` David Howells [this message]
2017-01-27 14:01 ` Matt Fleming
2017-01-31 14:02 ` David Howells
2017-01-30 12:10 ` What should the default lockdown mode be if the bootloader sentinel triggers sanitization? David Howells
2017-01-30 13:50 ` Matt Fleming
2017-01-30 14:01 ` David Howells
2017-01-31 11:57 ` Matt Fleming
2016-12-08 12:30 ` [PATCH 6/8] efi: Disable secure boot if shim is in insecure mode [ver #6] David Howells
2016-12-08 12:31 ` [PATCH 7/8] efi: Handle secure boot from UEFI-2.6 " David Howells
2016-12-08 12:31 ` [PATCH 8/8] efi: Add EFI_SECURE_BOOT bit " David Howells
2017-01-11 14:51 ` Matt Fleming
2017-01-11 15:29 ` David Howells
2017-01-16 13:40 ` Matt Fleming
2017-01-16 15:40 ` David Howells
2017-01-11 15:01 ` [PATCH 0/8] efi: Pass secure boot mode to kernel " Matt Fleming
2017-01-11 15:05 ` Ard Biesheuvel
2017-01-24 17:15 ` Ard Biesheuvel
2017-01-27 18:03 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6306.1485209503@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox