From: Jens Axboe <axboe@kernel.dk>
To: Ladvine D Almeida <ladvine.dalmeida@synopsys.com>,
Parshuram Raju Thombare <pthombar@cadence.com>,
Eric Biggers <ebiggers@kernel.org>
Cc: "vinholikatti@gmail.com" <vinholikatti@gmail.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Alan Douglas <adouglas@cadence.com>,
Janek Kotas <jank@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>,
AnilKumar Chimata <anilc@codeaurora.org>,
Satya Tangirala <satyat@google.com>,
Paul Crowley <paulcrowley@google.com>,
Manjunath M Bettegowda <manjunath.mb@synopsys.com>,
Tejas Joglekar <tejas.joglekar@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 2/2] scsi: ufs: add inline crypto support to UFS HCD
Date: Thu, 13 Dec 2018 13:11:58 -0700 [thread overview]
Message-ID: <6309baec-bb1f-4986-6872-a70047fbc469@kernel.dk> (raw)
In-Reply-To: <BD7FB879CC136E419544C8E2AE7B9C30227F0B@IN01WEMBXA.internal.synopsys.com>
On 12/13/18 1:04 PM, Ladvine D Almeida wrote:
> On 13/12/18 7:42 PM, Jens Axboe wrote:
>> On 12/13/18 12:39 PM, Ladvine D Almeida wrote:
>>> Suggest to take a look into the article https://urldefense.proofpoint.com/v2/url?u=https-3A__lwn.net_Articles_717754&d=DwICaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=z00zRD9ARrwHpe-XSl1OtUp1uNKGYoXI1G2DhOaDDBI&m=-pGzV3wdSje337vKOYoYB6NgU_DGDmQvfQ9egLDRYNQ&s=c4FXsrwD0BLAjE4UC47R2ngLnx_DP5jiOr0dtZ7tGsw&e=
>>> My real concern is how to achieve it without any modifications to the
>>> bio.(because key slot information has to finally reach the target block
>>> device)
>>
>> Guys, you both need to edit when you reply, wading through 650 lines of
>> text to get to this...
> Jens, Thanks for your reply. I will take care of it next time onwards. :-)
>
>>
>> You obviously can't modify the bio if you don't own it, but you could
>> clone it and then you have storage in ->bi_private.
>>
>
> I agree. I can clone the bio in the crypto target and use bi_private.
> But, when i finally submit the bio and it reaches the target block
> device, the information stored in bi_private is lost.
I don't follow, what do you mean it's lost? It's persistent from
bio setup to end_io time.
--
Jens Axboe
next prev parent reply other threads:[~2018-12-13 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 9:50 [PATCH 2/2] scsi: ufs: add inline crypto support to UFS HCD Parshuram Thombare
2018-12-11 12:03 ` Greg KH
2018-12-12 5:29 ` Parshuram Raju Thombare
2018-12-11 14:07 ` Christoph Hellwig
2018-12-11 18:16 ` Eric Biggers
2018-12-12 5:51 ` Parshuram Raju Thombare
2018-12-13 19:39 ` Ladvine D Almeida
2018-12-13 19:42 ` Jens Axboe
2018-12-13 20:04 ` Ladvine D Almeida
2018-12-13 20:11 ` Jens Axboe [this message]
2018-12-14 5:43 ` Parshuram Raju Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6309baec-bb1f-4986-6872-a70047fbc469@kernel.dk \
--to=axboe@kernel.dk \
--cc=Joao.Pinto@synopsys.com \
--cc=adouglas@cadence.com \
--cc=akpm@linux-foundation.org \
--cc=anilc@codeaurora.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=ladvine.dalmeida@synopsys.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manjunath.mb@synopsys.com \
--cc=martin.petersen@oracle.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=paulcrowley@google.com \
--cc=pthombar@cadence.com \
--cc=rafalc@cadence.com \
--cc=satyat@google.com \
--cc=tejas.joglekar@synopsys.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox