From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02D30345754 for ; Thu, 4 Dec 2025 13:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855371; cv=none; b=dkUMwS8/zhU5TSOL63z/R/rfFUS5tVAQskKDM3t8gMtuKC24l00DViSprutOjqtxIJqGV0fufKAg6AWS9Sn/wwAKMQExZI9Q936p52JQQQx5A14EJfMowndryZf73MRWBWggbtoTxUwOomek9hYL+J2G3QNJDWC32Zz5UNy3qlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764855371; c=relaxed/simple; bh=EBhBECdIgPVCEsnqU8fgxpEweU3NQdqUzWklhP+V00Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LhOp26l0DqisyJJdh/UxSLxpfCEDCrn7rkI8LUREzn/R/7GeEL48Z62Wm/qeIB8e5Amuz8cHJ4/hv1/pM41oyXxBKYtCNiABfY9183ZBjRUSSiCzpOdRLh7WjQCfWwzK1d8sYvPBMes0KV/To8BEbYmquRGC6ls3qhHiZwM9Qco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Rh+EXQz5; arc=none smtp.client-ip=95.215.58.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Rh+EXQz5" Message-ID: <6320fb67-4ed7-43c4-a4b6-48ebed2b473f@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1764855364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cvSG6kYMPnVqioq2FxZSj93YJSFBOQAlFZy4eN5bxag=; b=Rh+EXQz5eAoN88EoHzwiYORvMwIKZLeHA+SlotL4leDn5GF9FaJHFSld2QwqRo9v2S/S6+ J2K2XPtVtSPGA0r92eQU2Zr3ZeY1Q70mLeevh8daRmvyjDkbwariZFv4wUvzHCk952WTXY ocjPEG/GwvhyxvQekIEngSjWiJM67BU= Date: Thu, 4 Dec 2025 21:35:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH -next v2] mm: vmscan: correct nr_requested tracing in scan_folios Content-Language: en-US To: Chen Ridong Cc: linux-mm@kvack.org, david@kernel.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, linux-kernel@vger.kernel.org, lujialin4@huawei.com, chenridong@huawei.com, hannes@cmpxchg.org, yuanchu@google.com, weixugc@google.com, axelrasmussen@google.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, yuzhao@google.com, jaewon31.kim@samsung.com, mhocko@kernel.org, ioworker0@gmail.com References: <20251204122355.1822919-1-chenridong@huaweicloud.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <20251204122355.1822919-1-chenridong@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2025/12/4 20:23, Chen Ridong wrote: > From: Chen Ridong > > When enabling vmscan tracing, it is observed that nr_requested is always > 4096, which is confusing. > > mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ... > mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ... > mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ... > mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ... > mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ... > mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ... > mm_vmscan_lru_isolate: classzone=3 order=0 nr_requested=4096 ... > > This is because it prints MAX_LRU_BATCH, which is meaningless as it's a > constant. To fix this, modify it to print capped valued. > > Fixes: 8c2214fc9a47 ("mm: multi-gen LRU: reuse some legacy trace events") > Signed-off-by: Chen Ridong > --- LGTM, feel free to add: Reviewed-by: Lance Yang