From: Christian Marangi <ansuelsmth@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: James Smart <jsmart2021@gmail.com>,
Marc Herbert <marc.herbert@intel.com>,
Michael Turquette <mturquette@baylibre.com>,
Justin Tee <justin.tee@broadcom.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Christian Brauner <brauner@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v5 2/5] dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml
Date: Wed, 14 Sep 2022 18:54:08 +0200 [thread overview]
Message-ID: <63220732.500a0220.f190b.97f9@mx.google.com> (raw)
In-Reply-To: <1663174030.721715.2567034.nullmailer@robh.at.kernel.org>
On Wed, Sep 14, 2022 at 11:47:10AM -0500, Rob Herring wrote:
> On Wed, 14 Sep 2022 16:22:53 +0200, Christian Marangi wrote:
> > Convert kpss-acc driver Documentation to yaml.
> > The original Documentation was wrong all along. Fix it while we are
> > converting it.
> > The example was wrong as kpss-acc-v2 should only expose the regs but we
> > don't have any driver that expose additional clocks. The kpss-acc driver
> > is only specific to v1. For this exact reason, limit all the additional
> > bindings (clocks, clock-names, clock-output-names and #clock-cells) to
> > v1 and also flag that these bindings should NOT be used for v2.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > .../bindings/arm/msm/qcom,kpss-acc.txt | 49 ----------
> > .../bindings/arm/msm/qcom,kpss-acc.yaml | 93 +++++++++++++++++++
> > 2 files changed, 93 insertions(+), 49 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.txt
> > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> clock-controller@2088000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2088000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@2098000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
> arch/arm/boot/dts/qcom-ipq8064-ap148.dtb
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dtb
> arch/arm/boot/dts/qcom-msm8960-cdp.dtb
>
> clock-controller@20a8000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20a8000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: '#clock-cells' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clock-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clock-output-names' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
> clock-controller@20b8000: 'clocks' is a required property
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dtb
> arch/arm/boot/dts/qcom-apq8064-cm-qs600.dtb
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dtb
> arch/arm/boot/dts/qcom-apq8064-sony-xperia-lagan-yuga.dtb
>
Hi,
I fixed these warning in the last 2 commit of this series.
--
Ansuel
next prev parent reply other threads:[~2022-09-14 16:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 14:22 [PATCH v5 0/5] Krait Documentation conversion Christian Marangi
2022-09-14 14:22 ` [PATCH v5 1/5] dt-bindings: clock: Convert qcom,krait-cc to yaml Christian Marangi
2022-09-14 14:22 ` [PATCH v5 2/5] dt-bindings: arm: msm: Convert kpss-acc driver Documentation " Christian Marangi
2022-09-14 16:47 ` Rob Herring
2022-09-14 16:54 ` Christian Marangi [this message]
2022-09-16 19:17 ` Rob Herring
2022-09-16 19:42 ` Christian Marangi
2022-09-16 20:06 ` Dmitry Baryshkov
2022-09-16 20:13 ` Christian Marangi
2022-09-16 20:22 ` Dmitry Baryshkov
2022-09-16 20:27 ` Christian Marangi
2022-09-16 20:31 ` Dmitry Baryshkov
2022-09-16 21:54 ` Christian Marangi
2022-09-17 13:45 ` Dmitry Baryshkov
2022-09-17 18:57 ` Christian Marangi
2022-09-17 19:44 ` Christian Marangi
2022-09-17 20:46 ` Dmitry Baryshkov
2022-09-17 20:58 ` Christian Marangi
2022-09-14 14:22 ` [PATCH v5 3/5] dt-bindings: arm: msm: Rework kpss-gcc " Christian Marangi
2022-09-14 16:47 ` Rob Herring
2022-09-15 9:34 ` Krzysztof Kozlowski
2022-09-16 19:19 ` Rob Herring
2022-09-14 14:22 ` [PATCH v5 4/5] ARM: dts: qcom: fix various wrong definition for kpss-gcc node Christian Marangi
2022-12-23 10:17 ` Krzysztof Kozlowski
2022-12-23 10:17 ` Krzysztof Kozlowski
2022-09-14 14:22 ` [PATCH v5 5/5] ARM: dts: qcom: fix various wrong definition for kpss-acc Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63220732.500a0220.f190b.97f9@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=adobriyan@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=brauner@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jsmart2021@gmail.com \
--cc=justin.tee@broadcom.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.herbert@intel.com \
--cc=martin.petersen@oracle.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox