From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m32107.qiye.163.com (mail-m32107.qiye.163.com [220.197.32.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAA43284B33 for ; Mon, 19 May 2025 14:53:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.107 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747666385; cv=none; b=B9y1hMeL8YRhykG+UVCW4zX2jlmmGS5Z8H/PW8OHNmWgWA59IH707MMqkBlVHBmjEZckTv8CIfm8qF0Jxj7SvqLH1f4jRAmhA0tEUE9ohXPBGQHH/eb5wODQXigS9u6pErSFdHhPP8nFLt+zCrr+BO8a3RhtZ5raLGUmzVXibxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747666385; c=relaxed/simple; bh=WmI7AxznM9GYrbjWx0YCMnqw7/PHuW0zL01AhL4/OVU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MB9l47fpwNGRRs+mLQH7tVaFTZ0YMddvG4VD22sDDHsuHA2X54KoFObxmeJVBgeSmfRny0d91wdohLsS33JCAVdoupXAO22sEMSnH373LIHxQOHWZt+1IH21Zk9OFpW7OUq6yFTWxSPQlqEcHnaUdpTw5omCPimI/5++/pF7YkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Ka8twIly; arc=none smtp.client-ip=220.197.32.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Ka8twIly" Received: from [127.0.0.1] (gy-adaptive-ssl-proxy-2-entmail-virt205.gy.ntes [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 1587f7efd; Mon, 19 May 2025 14:56:29 +0800 (GMT+08:00) Message-ID: <632f9f4d-ec0f-4512-a153-d2abfd9f6841@rock-chips.com> Date: Mon, 19 May 2025 14:56:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml To: Krzysztof Kozlowski , Chaoyi Chen , Sandy Huang , Heiko Stuebner , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Dragan Simic , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250519012632.94-1-kernel@airkyi.com> <20250519012632.94-3-kernel@airkyi.com> <20a565da-296c-4920-b962-e9de9af464d9@kernel.org> From: Chaoyi Chen In-Reply-To: <20a565da-296c-4920-b962-e9de9af464d9@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUoaHlZOQk1KQxlMSktIH0lWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ X-HM-Tid: 0a96e754661603aekunm1587f7efd X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PAg6LBw5FzE0Ii4jMSsLPxlL MxAKCzpVSlVKTE9MTUhMTEJNQk1JVTMWGhIXVRgTGhQCElUYEx4VOwkUGBBWGBMSCwhVGBQWRVlX WRILWUFZTkNVSUlVTFVKSk9ZV1kIAVlBT01NSTcG DKIM-Signature:a=rsa-sha256; b=Ka8twIlywrsVRoj8joZuMcW3eNbHX7gY7ch+iU1OHqX+6+7zslvXArine9mFteoTl/apcyN/gJRi0rs4lA8aCiHKEcxuT/dJ7AIfildpe4TLr1kzqyGoOPdKAdnX7qs7DB+0IGfmX/oWgPABuzmw66/CvdowapfJaSyrpYJzR+0=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=eU+WAthWlgyCACOPm0qsanWlkKCLEJIXdLnn+HPfHms=; h=date:mime-version:subject:message-id:from; Hi Krzysztof, On 2025/5/19 14:16, Krzysztof Kozlowski wrote: > On 19/05/2025 03:26, Chaoyi Chen wrote: >> +maintainers: >> + - Andy Yan >> + - Heiko Stuebner >> + - Sandy Huang >> + >> +allOf: >> + - $ref: /schemas/sound/dai-common.yaml# >> + >> +properties: >> + compatible: >> + items: >> + - const: rockchip,rk3399-cdn-dp >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: DP core work clock >> + - description: APB clock >> + - description: SPDIF interface clock >> + - description: GRF clock >> + >> + clock-names: >> + items: >> + - const: core-clk >> + - const: pclk >> + - const: spdif >> + - const: grf >> + >> + extcon: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + items: >> + maxItems: 1 >> + maxItems: 2 > Instead of this, list the items. Old binding said only "specifier", so > this is technically a change, which should be explained in commit msg. Will fix in v5. > >> + description: >> + List of phandle to the extcon device providing the cable state for the DP PHY. >> + >> + interrupts: >> + maxItems: 1 >> + >> + phys: >> + items: >> + maxItems: 1 >> + maxItems: 2 >> + description: | >> + List of phandle to the PHY device for DP output. >> + RK3399 have two DP-TPYEC PHY, specifying one PHY which want to use, >> + or specify two PHYs here to let the driver determine which PHY to use. > > You do not allow one phy, so your description is not accurate. OTOH, > original binding did not allow two phandles, so that's another change in > the binding. You need to document all changes done to the binding in the > commit msg. Oh, the original binding example use two phandles. I think only one PHY can also pass the dtb check here, or maybe I'm missing something else? > >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: Input of the CDN DP >> + properties: >> + endpoint@0: >> + description: Connection to the VOPB >> + endpoint@1: >> + description: Connection to the VOPL >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: Output of the CDN DP >> + >> + required: >> + - port@0 >> + - port@1 >> + >> + power-domains: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 4 >> + >> + reset-names: >> + items: >> + - const: spdif >> + - const: dptx >> + - const: apb >> + - const: core >> + >> + rockchip,grf: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + Phandle to GRF register to control HPD. >> + >> + "#sound-dai-cells": >> + const: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - interrupts >> + - phys >> + - ports >> + - resets >> + - reset-names >> + - rockchip,grf > > sound-dai-cells was a required property. > Okay, will add in v5.