From: Pankaj Gupta <pagupta@redhat.com>
To: dan j williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
vishal l verma <vishal.l.verma@intel.com>,
dave jiang <dave.jiang@intel.com>,
keith busch <keith.busch@intel.com>,
ira weiny <ira.weiny@intel.com>
Subject: Re: [PATCH] libnvdimm: change disk name of virtio pmem disk
Date: Tue, 13 Aug 2019 00:55:37 -0400 (EDT) [thread overview]
Message-ID: <633367382.8144845.1565672137069.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190731111207.12836-1-pagupta@redhat.com>
Ping.
>
> This patch adds prefix 'v' in disk name for virtio pmem.
> This differentiates virtio-pmem disks from the pmem disks.
>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> ---
> drivers/nvdimm/namespace_devs.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/namespace_devs.c
> b/drivers/nvdimm/namespace_devs.c
> index a16e52251a30..8e5d29266fb0 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -182,8 +182,12 @@ const char *nvdimm_namespace_disk_name(struct
> nd_namespace_common *ndns,
> char *name)
> {
> struct nd_region *nd_region = to_nd_region(ndns->dev.parent);
> + const char *prefix = "";
> const char *suffix = NULL;
>
> + if (!is_nvdimm_sync(nd_region))
> + prefix = "v";
> +
> if (ndns->claim && is_nd_btt(ndns->claim))
> suffix = "s";
>
> @@ -201,7 +205,7 @@ const char *nvdimm_namespace_disk_name(struct
> nd_namespace_common *ndns,
> sprintf(name, "pmem%d.%d%s", nd_region->id, nsidx,
> suffix ? suffix : "");
> else
> - sprintf(name, "pmem%d%s", nd_region->id,
> + sprintf(name, "%spmem%d%s", prefix, nd_region->id,
> suffix ? suffix : "");
> } else if (is_namespace_blk(&ndns->dev)) {
> struct nd_namespace_blk *nsblk;
> --
> 2.20.1
>
>
next prev parent reply other threads:[~2019-08-13 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 11:12 [PATCH] libnvdimm: change disk name of virtio pmem disk Pankaj Gupta
2019-08-13 4:55 ` Pankaj Gupta [this message]
2019-08-15 17:28 ` Dan Williams
2019-08-16 7:36 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=633367382.8144845.1565672137069.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox