Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver

Baolu Lu
2022-05-25T06:26:46Z

On 2022/5/25 09:31, Nobuhiro Iwamatsu wrote:
> +static const struct iommu_ops visconti_atu_ops = {
> + .domain_alloc = visconti_atu_domain_alloc,
> + .probe_device = visconti_atu_probe_device,
> + .release_device = visconti_atu_release_device,
> + .device_group = generic_device_group,
> + .of_xlate = visconti_atu_of_xlate,
> + .pgsize_bitmap = ATU_IOMMU_PGSIZE_BITMAP,
> + .default_domain_ops = &(const struct iommu_domain_ops) {
> + .attach_dev = visconti_atu_attach_device,
> + .detach_dev = visconti_atu_detach_device,

The detach_dev callback is about to be deprecated. The new drivers
should implement the default domain and blocking domain instead.

> + .map = visconti_atu_map,
> + .unmap = visconti_atu_unmap,
> + .iova_to_phys = visconti_atu_iova_to_phys,
> + .free = visconti_atu_domain_free,
> + }
> +};

Best regards,
baolu